Exit tests shouldn't emit crash logs. #670
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a process crashes, the platforms we support all write a crash log (or core, or error report) to disk. This is not necessary for exit test child processes (since we intentionally crash them.) This PR suppresses generation of those logs from within an exit test: - On Darwin, we disable the exception port for crash report files; - On Linux, we set the maximum core dump size to zero bytes; and - On Windows, we disable Windows Error Reporting. The above effects are only applied to the exit test's child process, not to the parent test process nor the system as a whole.
grynspan
added
enhancement
grynspan
requested review from
stmontgomery,
dennisweissmann,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
|
@swift-ci test |
briancroom
reviewed
Sep 6, 2024
|
@swift-ci test |
compnerd
approved these changes
Sep 6, 2024
stmontgomery
approved these changes
Sep 6, 2024
|
@swift-ci test |
grynspan
deleted the
jgrynspan/call-posix_spawnattr_setexceptionports_np
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a process crashes, the platforms we support all write a crash log (or core, or error report) to disk. This is not necessary for exit test child processes (since we intentionally crash them.)
This PR suppresses generation of those logs from within an exit test:
The above effects are only applied to the exit test's child process, not to the parent test process nor the system as a whole.
Checklist: