Include total number of suites in "run ended" console message #1116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stmontgomery
requested review from
briancroom,
grynspan and
suzannaratcliff
as code owners
stmontgomery
added
enhancement
Contributor
Author
|
@swift-ci please test |
stmontgomery
commented
May 15, 2025
| Message( | ||
| symbol: .fail, | ||
| stringValue: "Test run with \(testCount.counting("test")) failed after \(duration)\(issues.description)." | ||
| stringValue: "Test run with \(testCount.counting("test")) in \(suiteCount.counting("suite")) failed after \(duration)\(issues.description)." |
Contributor
Author
There was a problem hiding this comment.
I chose the word "in" here, although we could alternatively choose "and", as in Test run with X tests and Y suites passed…. Open to suggestions.
Contributor
|
Nice, I like it! |
briancroom
approved these changes
May 16, 2025
finagolfin
added a commit
to swiftlang/swift-integration-tests
that referenced
this pull request
May 17, 2025
finagolfin
added a commit
to swiftlang/swift-integration-tests
that referenced
this pull request
May 25, 2025
finagolfin
added a commit
to swiftlang/swift-integration-tests
that referenced
this pull request
May 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enhances the console output message shown when a test run finishes by including the total number of suites which ran or skipped, after the total number of test functions. Example:
The data was already being collected to support this, in a property named
suiteCount, but it was not being used anywhere. So this PR adopts that property to augment the current "test run ended" message.Checklist: