Skip to content

Enable experimental 'AllowUnsafeAttribute' feature to continue supporting 6.1 development snapshot toolchains #1084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

stmontgomery
Copy link
Contributor

This fixes a build failure when attempting to build the main branch using a 6.1 development snapshot toolchain. This failure was introduced by #1069, which added usage of the new @unsafe attribute, and the failure was revealed when we set up the 6.1 CI jobs in #1083.

Here are some relevant related Swift PRs which give context around these changes:

See the code comment for more details.

Checklist:

  • Code and documentation should follow the style of the Style Guide.
  • If public symbols are renamed or modified, DocC references should be updated.

@stmontgomery stmontgomery added bug 🪲 Something isn't working build 🧱 Affects the project's build configuration or process labels Apr 18, 2025
@stmontgomery stmontgomery added this to the Swift 6.x milestone Apr 18, 2025
@stmontgomery stmontgomery self-assigned this Apr 18, 2025
@stmontgomery
Copy link
Contributor Author

@swift-ci please test

@stmontgomery
Copy link
Contributor Author

@swift-ci please test macOS

@stmontgomery
Copy link
Contributor Author

The macOS CI failure is expected to be resolved by swiftlang/swift#80830.

@stmontgomery stmontgomery merged commit 05ae424 into swiftlang:main Apr 19, 2025
2 of 3 checks passed
@stmontgomery stmontgomery deleted the enable-AllowUnsafeAttribute branch April 19, 2025 00:54
@stmontgomery stmontgomery modified the milestones: Swift 6.x, Swift 6.2 Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working build 🧱 Affects the project's build configuration or process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants