Skip to content

Bump the Swift version to 6.1.2 #1061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 8, 2025
Merged

Bump the Swift version to 6.1.2 #1061

merged 1 commit into from
Apr 8, 2025

Conversation

shahmishal
Copy link
Member

No description provided.

@shahmishal shahmishal mentioned this pull request Apr 8, 2025
Merged
stmontgomery
stmontgomery approved these changes Apr 8, 2025
View reviewed changes
Copy link
Contributor

@stmontgomery stmontgomery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we figure out some way to inject this version when the toolchain build is performed so we don't have to hardcode and keep adjusting it manually in a bunch of places?

@grynspan
Copy link
Contributor

grynspan commented Apr 8, 2025

That remains an open question. Ours is not the only component with this problem.

@stmontgomery stmontgomery mentioned this pull request Apr 8, 2025
Open
@stmontgomery
Copy link
Contributor

I took a quick look and think there may be a viable way to plumb this info through the build-script / CMake build. I filed #1063.

@grynspan grynspan merged commit 914c403 into release/6.1 Apr 8, 2025
@grynspan grynspan deleted the bump-swift-version-6.1.2 branch April 8, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stmontgomery stmontgomery stmontgomery approved these changes

@grynspan grynspan grynspan approved these changes

@dennisweissmann dennisweissmann Awaiting requested review from dennisweissmann dennisweissmann is a code owner

@briancroom briancroom Awaiting requested review from briancroom briancroom is a code owner

@SeanROlszewski SeanROlszewski Awaiting requested review from SeanROlszewski SeanROlszewski is a code owner

@suzannaratcliff suzannaratcliff Awaiting requested review from suzannaratcliff suzannaratcliff is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shahmishal @grynspan @stmontgomery