Skip to content

Move result builder as last parameters #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kimdv
Copy link
Contributor

@kimdv kimdv commented Jun 23, 2021

Moved the result builders to end end of init parameters. This will give a more clean code.

Idea from #291

Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ahoppen
Copy link
Member

ahoppen commented Jun 24, 2021

@swift-ci Please test

@ahoppen ahoppen self-assigned this Jun 24, 2021
@ahoppen ahoppen merged commit 0793d1a into swiftlang:main Jun 25, 2021
@kimdv kimdv deleted the kimdv/make-result-builders-as-last-parameter branch September 5, 2021 07:26
adevress pushed a commit to adevress/swift-syntax that referenced this pull request Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants