Skip to content

[6.0] Increase tools version #2801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 12, 2024
Merged

[6.0] Increase tools version #2801

merged 1 commit into from
Aug 12, 2024

Conversation

SimplyDanny
Copy link
Contributor

@SimplyDanny SimplyDanny commented Aug 11, 2024 •
edited by ahoppen
Loading

  • Explanation: With the changes from [6.0] Performance improvements for SyntaxRewriter #2742 in SyntaxRewriter requires stdlib functions introduced alongside with Swift 5.8. Increase the swift tools version to reflect that version requirement.
  • Scope: swift-syntax as a package dependency
  • Risk: Low, swift-syntax doesn’t build with Swift <5.8 currently anyway
  • Testing: n/a
  • Issue: n/a
  • Reviewer: @ahoppen

@SimplyDanny
Increase tools version
b1ff169 
The changes introduced by swiftlang#2742 in SyntaxRewriter require at least Swift 5.8.
@SimplyDanny SimplyDanny mentioned this pull request Aug 11, 2024
Closed
ahoppen
ahoppen approved these changes Aug 12, 2024
View reviewed changes
Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @SimplyDanny

@ahoppen ahoppen changed the title Increase tools version [6.0] Increase tools version Aug 12, 2024
@ahoppen
Copy link
Member

ahoppen commented Aug 12, 2024

@SimplyDanny Would you like to also create a PR for this to main?

@ahoppen
Copy link
Member

ahoppen commented Aug 12, 2024

@swift-ci Please test

@ahoppen ahoppen enabled auto-merge August 12, 2024 19:05
@SimplyDanny
Copy link
Contributor Author

@SimplyDanny Would you like to also create a PR for this to main?

Sure. There it is: #2802.

@ahoppen ahoppen merged commit 515f79b into swiftlang:release/6.0 Aug 12, 2024
3 checks passed
@SimplyDanny SimplyDanny deleted the increase-compiler-version branch August 12, 2024 21:52
@jessesquires jessesquires mentioned this pull request Aug 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnbarham bnbarham bnbarham approved these changes

@ahoppen ahoppen ahoppen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SimplyDanny @ahoppen @bnbarham