[6.0] Add option to install targets even when not top level #2637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ahoppen
commented
May 2, 2024
ahoppen
commented
- Explanation: Also add namespaced targets for any exported target to facilitate find_package and FetchContent both using the same target names.
- Scope: CMake build
- Risk: Any issues will be caught at build-time
- Testing: n/a
- Issue: n/a
- Reviewer: @bnbarham on Add option to install targets even when not top level #2628
Also add namespaced targets for any exported target to facilitate find_package and FetchContent both using the same target names.
1 similar comment
|
Thanks (and sorry for not cherry-picking) |
bnbarham
approved these changes
May 2, 2024
|
@swift-ci Please test Windows |
|
@swift-ci Please test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.