build: add an option to control WMO #1705
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
bnbarham
reviewed
May 25, 2023
WMO requires the new swift-driver which requires an early swift-driver or a host toolchain that has Swift. Since the only platform that guarantees this currently is Darwin, use a conditional value for the option, defaulting to `NO` for most other targets. This should repair the build on Windows.
bnbarham
approved these changes
May 25, 2023
There was a problem hiding this comment.
Thanks @compnerd! I'll set this by default in swiftlang/swift#66043 as well (since we assume there's a host toolchain there).
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
|
@swift-ci please test macOS platform |
|
@swift-ci please test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WMO requires the new swift-driver which requires an early swift-driver or a host toolchain that has Swift. Since the only platform that guarantees this currently is Darwin, use a conditional value for the option, defaulting to
NOfor most other targets. This should repair the build on Windows.