Split SyntaxNodes.swift.gyb into multiple files #165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
changed the title
ahoppen
force-pushed
the
split-syntaxnodes-gyb
branch
2 times, most recently
from
605819f to
bfa0ddc
Compare
This was referenced Oct 31, 2019
|
@swift-ci Please test |
harlanhaskins
approved these changes
Nov 5, 2019
This way the generated files get a more managable size and can be viewed more easily.
ahoppen
force-pushed
the
split-syntaxnodes-gyb
branch
from
bfa0ddc to
65a49c4
Compare
|
@swift-ci Please test |
|
Let’s use this PR to verify that SwiftSyntax PR testing is testing the stress tester as well using the updated preset. @swift-ci Please test |
adevress
pushed a commit
to adevress/swift-syntax
that referenced
this pull request
Jan 14, 2024
Force breaking in repeat body when while condition is too long.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment
SyntaxNodes.swift.gybis a giant files that does all sorts of things and the generated file is even larger. This PR aims to split it up into manageable parts so that even the generated files can be viewed in Xcode.The specific moves I did were:
Syntax-related stuff toSyntax.swiftwithLeadingTriviaand friends toSyntaxProtocolso we only need to specify it onceSyntaxEnumto a new fileSyntaxEnum.swift.gybSyntaxTraits.swift.gybSyntaxNodeand the syntax parser version verification toMisc.swift.gybSyntaxNodes.swift.gyb; one for every base kind likeSyntaxExprNodes.swiftetc.UnknownSyntaxandTokenSyntaxtoSyntaxOtherNodes.swiftThis change also improves debug compile times by 2x. The release compile time seems to stay roughly the same.
Note: I am planning to squash the various commits before merging, I just want to keep them around for now if I need to make any more changes.