Add new swift-crypto on asn1 to the bootstrap script #8297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmcgee1024
requested review from
MaxDesiatov,
bkhouri,
bnbarham,
bripeticca,
dschaefer2,
jakepetroules,
owenv,
plemarquand,
shawnhyam and
xedin
as code owners
|
@swift-ci please test |
jakepetroules
approved these changes
Feb 17, 2025
bripeticca
pushed a commit
to bripeticca/swift-package-manager
that referenced
this pull request
Feb 28, 2025
Add new swift-crypto on asn1 to the bootstrap script ### Motivation: The newest version of swift-crypto has a dependency on swift-asn1. Without providing the directory the CMakeLists.txt of swift-crypto will attempt to vendor a specific version of that library that may not match what is in the update-checkout version using in Swift CI, which can lead to mismatched symbols during linking. ### Modifications: This fix adds the swift-asn1 dependency to swift-crypto by adding the directory for swift-asn1 to cmake when building swift-crypto. ### Result: After the change the new dependency from swift-crypto should be ready for when the new version of the lib is adopted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new swift-crypto on asn1 to the bootstrap script
Motivation:
The newest version of swift-crypto has a dependency on swift-asn1. Without providing the directory the CMakeLists.txt of swift-crypto will attempt to vendor a specific version of that library that may not match what is in the update-checkout version using in Swift CI, which can lead to mismatched symbols during linking.
Modifications:
This fix adds the swift-asn1 dependency to swift-crypto by adding the directory for swift-asn1 to cmake when building swift-crypto.
Result:
After the change the new dependency from swift-crypto should be ready for when the new version of the lib is adopted.