Return compiler arguments for invalid package manifests #8138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, when there‘s a syntax error in a package manifest, we don’t get any build settings from it in SourceKit-LSP and thus loose almost all semantic functionality. If we can’t parse the package manifest, fall back to providing build settings by assuming it has the current Swift tools version. Fixes swiftlang/sourcekit-lsp#1704 rdar://136423767
ahoppen
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
francescomikulis,
xedin,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand and
owenv
as code owners
|
@swift-ci Please test |
plemarquand
approved these changes
Nov 23, 2024
| guard self.currentToolsVersion >= manifestToolsVersion || SwiftVersion.current.isDevelopment, | ||
| manifestToolsVersion >= ToolsVersion.minimumRequired | ||
| else { | ||
| throw StringError("invalid tools version") |
There was a problem hiding this comment.
nit: can you include the invalid tools version in the string to make the issue easier to debug?
There was a problem hiding this comment.
Does this error path also have corresponding test coverage here?
There was a problem hiding this comment.
I just shuffled code around and I don’t know how I would trigger this error scenario.
ahoppen
added a commit
that referenced
this pull request
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when there‘s a syntax error in a package manifest, we don’t get any build settings from it in SourceKit-LSP and thus loose almost all semantic functionality. If we can’t parse the package manifest, fall back to providing build settings by assuming it has the current Swift tools version.
Fixes swiftlang/sourcekit-lsp#1704
rdar://136423767