Tests: Disable assert in TraitTests #8132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The assertion in `TraitTets` that ensured warnigs do not appear in stderr are failing against the 6.1 toolchain. Since 1) this test was never executed against macOS, since the self-hosted macOS pipeline was running Swift 5.9.2, and 2) work is underway to productive the Traits feature, it was decided to disable the assert for now, and open a GitHub issue to re-enable the assert with the production work. This change removes the assert for GitHub issue 8131, which must be re-enabled when the respective issue is fixed.
|
@swift-ci please test |
bkhouri
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
francescomikulis,
xedin,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand and
owenv
as code owners
dschaefer2
approved these changes
Nov 21, 2024
bkhouri
added a commit
to bkhouri/swift-package-manager
that referenced
this pull request
Nov 25, 2024
Disable assertion in `TraitTests`, which was never executed on macOS due to the self-hosted macOS pipeline running Swift 5.9..2, and test being wrapped around `#if compiler(>=6.0)` pre-processor. ### Motivation: The assertion in `TraitTets` that ensured warnigs do not appear in stderr are failing against the 6.1 toolchain. Since 1) this test was never executed against macOS, since the self-hosted macOS pipeline was running Swift 5.9.2, and 2) work is underway to productive the Traits feature, it was decided to disable the assert for now, and open a GitHub issue to re-enable the assert with the production work. This change removes the assert for GitHub issue 8131, which must be re-enabled when the respective issue is fixed. ### Modifications: Disabled assertion the the `TraitTests` ### Result: ``` swift test --filter "TraitTests" ``` ### NOTE: It is expected the assertions will be re-introduced when swiftlang#8131 is fixed. (cherry picked from commit dca0cc2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable assertion in
TraitTests, which was never executed on macOS due to the self-hosted macOS pipeline running Swift 5.9..2, and test being wrapped around#if compiler(>=6.0)pre-processor.Motivation:
The assertion in
TraitTetsthat ensured warnigs do not appear in stderr are failing against the 6.1 toolchain. Since 1) this test was never executed against macOS, since the self-hosted macOS pipeline was running Swift 5.9.2, and 2) work is underway to productive the Traits feature, it was decided to disable the assert for now, and open a GitHub issue to re-enable the assert with the production work.This change removes the assert for GitHub issue 8131, which must be re-enabled when the respective issue is fixed.
Modifications:
Disabled assertion the the
TraitTestsResult:
NOTE:
It is expected the assertions will be re-introduced when #8131 is fixed.