Skip to content

Android: import new Android overlay in more places #8115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

finagolfin
Copy link
Member

Also, fix one test and add the right path for touch in the plugin tests.

@dschaefer2, I use this patch to build both natively on Android and cross-compile for my Android CI. It would be good to get it in before the upcoming 6.1 branch: should be easy to review as it touches nothing outside Android and makes simple changes for Android.

Also, fix one test and add the right path for `touch` in the plugin tests.
@finagolfin
Copy link
Member Author

Ping @bnbarham, a CI run and we can get this in.

@bnbarham
Copy link
Contributor

@swift-ci please test

@bnbarham
Copy link
Contributor

I believe self-hosted has been having issues, but let's see 😬

@finagolfin
Copy link
Member Author

Self-hosted linux passed, but self-hosted mac CI appears to be broken for the last week, maybe because of some change in the macOS CI environment for self-hosted.

@dschaefer2
Copy link
Member

Yup, known issue with the macOS self hosted CI job. I'm waiting patiently for a fix. It's affecting all PRs at the moment.

@finagolfin
Copy link
Member Author

It looks like Mishal was working on it, re-ran this one a couple times, but it was always broken.

@dschaefer2
Copy link
Member

Yup, he assures me he's still working on it.

@finagolfin
Copy link
Member Author

@MaxDesiatov, would you merge?

@finagolfin
Copy link
Member Author

Ping @bnbarham, finally passed CI, ready for merge.

@dschaefer2
Copy link
Member

Thanks!

@dschaefer2 dschaefer2 merged commit 00a2e2f into swiftlang:main Nov 15, 2024
5 checks passed
@dschaefer2
Copy link
Member

BTW, I'm in Ottawa Canada time.

@finagolfin
Copy link
Member Author

BTW, I'm in Ottawa Canada time.

I know, I saw it on your github profile, which is why I didn't ask you 7 hours ago when I asked Max in London instead. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants