-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Android: import new Android overlay in more places #8115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Also, fix one test and add the right path for `touch` in the plugin tests.
Ping @bnbarham, a CI run and we can get this in. |
@swift-ci please test |
I believe self-hosted has been having issues, but let's see 😬 |
Self-hosted linux passed, but self-hosted mac CI appears to be broken for the last week, maybe because of some change in the macOS CI environment for self-hosted. |
Yup, known issue with the macOS self hosted CI job. I'm waiting patiently for a fix. It's affecting all PRs at the moment. |
It looks like Mishal was working on it, re-ran this one a couple times, but it was always broken. |
Yup, he assures me he's still working on it. |
@MaxDesiatov, would you merge? |
Ping @bnbarham, finally passed CI, ready for merge. |
Thanks! |
BTW, I'm in Ottawa Canada time. |
I know, I saw it on your github profile, which is why I didn't ask you 7 hours ago when I asked Max in London instead. 😄 |
Also, fix one test and add the right path for
touch
in the plugin tests.@dschaefer2, I use this patch to build both natively on Android and cross-compile for my Android CI. It would be good to get it in before the upcoming 6.1 branch: should be easy to review as it touches nothing outside Android and makes simple changes for Android.