Skip to content

Fix warnings caused by unused await #7756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Fix warnings caused by unused await #7756

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions Tests/PackageLoadingTests/ManifestLoaderCacheTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import XCTest
final class ManifestLoaderCacheTests: XCTestCase {

func testDBCaching() async throws {
try await UserToolchain.default.skipUnlessAtLeastSwift6()
try UserToolchain.default.skipUnlessAtLeastSwift6()

try await testWithTemporaryDirectory { path in
let fileSystem = localFileSystem
Expand Down Expand Up @@ -116,7 +116,7 @@ final class ManifestLoaderCacheTests: XCTestCase {
}

func testInMemoryCaching() async throws {
try await UserToolchain.default.skipUnlessAtLeastSwift6()
try UserToolchain.default.skipUnlessAtLeastSwift6()

let fileSystem = InMemoryFileSystem()
let observability = ObservabilitySystem.makeForTesting()
Expand Down Expand Up @@ -207,7 +207,7 @@ final class ManifestLoaderCacheTests: XCTestCase {
}

func testContentBasedCaching() async throws {
try await UserToolchain.default.skipUnlessAtLeastSwift6()
try UserToolchain.default.skipUnlessAtLeastSwift6()

try await testWithTemporaryDirectory { path in
let manifest = """
Expand Down Expand Up @@ -268,7 +268,7 @@ final class ManifestLoaderCacheTests: XCTestCase {
}

func testCacheInvalidationOnEnv() async throws {
try await UserToolchain.default.skipUnlessAtLeastSwift6()
try UserToolchain.default.skipUnlessAtLeastSwift6()

try await testWithTemporaryDirectory { path in
let fileSystem = InMemoryFileSystem()
Expand Down Expand Up @@ -335,7 +335,7 @@ final class ManifestLoaderCacheTests: XCTestCase {
}

func testCacheDoNotInvalidationExpectedEnv() async throws {
try await UserToolchain.default.skipUnlessAtLeastSwift6()
try UserToolchain.default.skipUnlessAtLeastSwift6()

try await testWithTemporaryDirectory { path in
let fileSystem = InMemoryFileSystem()
Expand Down Expand Up @@ -422,7 +422,7 @@ final class ManifestLoaderCacheTests: XCTestCase {
}

func testInMemoryCacheHappyCase() async throws {
try await UserToolchain.default.skipUnlessAtLeastSwift6()
try UserToolchain.default.skipUnlessAtLeastSwift6()

let content = """
import PackageDescription
Expand Down
6 changes: 3 additions & 3 deletions Tests/PackageLoadingTests/PD_6_0_LoadingTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ final class PackageDescription6_0LoadingTests: PackageDescriptionLoadingTests {
}

func testPackageContextGitStatus() async throws {
try await UserToolchain.default.skipUnlessAtLeastSwift6()
try UserToolchain.default.skipUnlessAtLeastSwift6()

let content = """
import PackageDescription
Expand All @@ -36,7 +36,7 @@ final class PackageDescription6_0LoadingTests: PackageDescriptionLoadingTests {
}

func testPackageContextGitTag() async throws {
try await UserToolchain.default.skipUnlessAtLeastSwift6()
try UserToolchain.default.skipUnlessAtLeastSwift6()

let content = """
import PackageDescription
Expand All @@ -50,7 +50,7 @@ final class PackageDescription6_0LoadingTests: PackageDescriptionLoadingTests {
}

func testPackageContextGitCommit() async throws {
try await UserToolchain.default.skipUnlessAtLeastSwift6()
try UserToolchain.default.skipUnlessAtLeastSwift6()

let content = """
import PackageDescription
Expand Down
2 changes: 1 addition & 1 deletion Tests/WorkspaceTests/InitTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,7 @@ final class InitTests: XCTestCase {
// MARK: Special case testing

func testInitPackageNonc99Directory() async throws {
try await UserToolchain.default.skipUnlessAtLeastSwift6()
try UserToolchain.default.skipUnlessAtLeastSwift6()
try await withTemporaryDirectory(removeTreeOnDeinit: true) { tempDirPath in
XCTAssertDirectoryExists(tempDirPath)

Expand Down
2 changes: 1 addition & 1 deletion Tests/WorkspaceTests/ManifestSourceGenerationTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -590,7 +590,7 @@ final class ManifestSourceGenerationTests: XCTestCase {
}

func testManifestGenerationWithSwiftLanguageVersion() async throws {
try await UserToolchain.default.skipUnlessAtLeastSwift6()
try UserToolchain.default.skipUnlessAtLeastSwift6()
let manifest = Manifest.createRootManifest(
displayName: "pkg",
path: "/pkg",
Expand Down
2 changes: 1 addition & 1 deletion Tests/WorkspaceTests/WorkspaceTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5252,7 +5252,7 @@ final class WorkspaceTests: XCTestCase {

// This verifies that the simplest possible loading APIs are available for package clients.
func testSimpleAPI() async throws {
try await UserToolchain.default.skipUnlessAtLeastSwift6()
try UserToolchain.default.skipUnlessAtLeastSwift6()

try await testWithTemporaryDirectory { path in
// Create a temporary package as a test case.
Expand Down