-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Move PackageCollectionsProtocol to async/await #7726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@swift-ci test |
❤️ negative diff PRs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much! 😊
3752418
to
30768dc
Compare
|
Something odd with importing _Concurrency seems to break on Linux? |
|
@swift-ci test |
@swift-ci test windows |
@ahoppen could the macOS failure be related to recent SourceKit-LSP changes?
|
@swift-ci test |
Move PackageCollectionsProtocol to async/await
Motivation:
async/await is easier to read and reason about then the callback APIs
Modifications:
PackageCollectionsProtocol is now expressed in terms of async methods instead of callbacks
callback to async bridge methods are removed
Replaced usage of DispatchGroup with async let
PackageMetadata init has default values for optional and array values
Result:
More readable code