Remove unused Codable conformances on PackageModel types
#7687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The conformances are unused and pull in an additional `TSCUtility.PolymorphicCodableProtocol` dependency.
MaxDesiatov
added
the
no functional change
|
@swift-ci test |
|
@swift-ci test |
|
@swift-ci test windows |
MaxDesiatov
requested review from
bnbarham,
jakepetroules,
francescomikulis and
xedin
as code owners
xedin
approved these changes
Jun 20, 2024
MaxDesiatov
added a commit
that referenced
this pull request
Jun 27, 2024
The conformances are unused and pull in an additional `TSCUtility.PolymorphicCodableProtocol` dependency. This change removes about 0.2-0.4 MB from final executables on macOS when comparing with `swift build -c release` to `main`. Also allows us to rename these types more easily to disambiguate between host/target triples and manifest targets/modules in our code. If there's an existing user of this JSON manifest serialization we're unaware of, they should rely on `swift package describe --type json` instead, which has stable, consistent, and tested output. (cherry picked from commit 9e5f8b7) # Conflicts: # Sources/PackageModel/BuildSettings.swift # Sources/PackageModel/Manifest/PackageConditionDescription.swift
MaxDesiatov
added a commit
that referenced
this pull request
Jun 27, 2024
Includes these PRs cherry-picked off `main` * #7605 * #7660 * #7667 * #7682 * #7687 * #7690 * #7684 * #7679 **Explanation**: Cherry-pick of recent NFC changes, which makes it easier to cherry-pick actual bug fixes onto 6.0 due to the reduced number of merge conflicts. **Scope**: broad, includes both modules graph and llbuild-related changes. **Risk**: low, the test suite is passing, no functional changes are included, and cherry-picked changes were incubated on `main` for some time. **Testing**: Existing automated test suite. **Issue**: N/A **Reviewers**: @xedin @MaxDesiatov @rauhul --------- Co-authored-by: Pavel Yaskevich <xedin@apache.org> Co-authored-by: Danny Mösch <danny.moesch@icloud.com> Co-authored-by: Rauhul Varma <rauhul@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The conformances are unused and pull in an additional
TSCUtility.PolymorphicCodableProtocoldependency. This change removes about 0.2-0.4 MB from final executables on macOS when comparing withswift build -c releasetomain.Also allows us to rename these types more easily to disambiguate between host/target triples and manifest targets/modules in our code.
If there's an existing user of this JSON manifest serialization we're unaware of, they should rely on
swift package describe --type jsoninstead, which has stable, consistent, and tested output.