Make modules graph loading async
#7672
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
MaxDesiatov
changed the title
async
|
Assuming this isn't the end state and loading the graph will still be optional? Otherwise, this will affect incremental build perf quite a bit. |
MaxDesiatov
force-pushed
the
maxd/early-graph-memoization
branch
from
c1ddf0c to
840979b
Compare
MaxDesiatov
changed the title
asyncasync
MaxDesiatov
changed the title
asyncasync
…xd/early-graph-memoization # Conflicts: # Sources/Build/BuildOperation.swift # Sources/Commands/PackageCommands/DumpCommands.swift # Sources/Commands/PackageCommands/InstalledPackages.swift # Sources/Commands/PackageCommands/PluginCommand.swift # Sources/Commands/Snippets/Cards/SnippetCard.swift # Sources/Commands/SwiftRunCommand.swift # Sources/Commands/SwiftTestCommand.swift # Sources/Commands/Utilities/PluginDelegate.swift # Sources/SPMBuildCore/Plugins/PluginInvocation.swift # Sources/Workspace/DefaultPluginScriptRunner.swift # Tests/SPMBuildCoreTests/PluginInvocationTests.swift
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should allow making
packageGraphLoaderasync, but this infects a most of the build system code, including the plugin delegate code.This unblocks the conversion of PubGrub code to Structured Concurrency.