Update diagnostics for duplicated product/target names #7572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdar://127623219
neonichu
requested review from
bnbarham,
MaxDesiatov,
jakepetroules and
francescomikulis
as code owners
neonichu
commented
May 16, 2024
| @@ -13015,17 +13015,9 @@ final class WorkspaceTests: XCTestCase { | |||
| do { | |||
| workspace.sourceControlToRegistryDependencyTransformation = .disabled | |||
|
|
|||
| XCTAssertThrowsError(try workspace.checkPackageGraph(roots: ["root"]) { _, diagnostics in | |||
| testDiagnostics(diagnostics) { result in | |||
There was a problem hiding this comment.
This was unreachable.
neonichu
commented
May 16, 2024
| @@ -13135,31 +13127,16 @@ final class WorkspaceTests: XCTestCase { | |||
|
|
|||
| do { | |||
| workspace.sourceControlToRegistryDependencyTransformation = .disabled | |||
| if ToolsVersion.current < .v5_8 { | |||
There was a problem hiding this comment.
This was obviously always false.
|
@swift-ci please test |
|
@neonichu could you please cherry-pick this to 6.0 branch as well? |
|
Sure #7575 |
xedin
pushed a commit
that referenced
this pull request
May 18, 2024
- Explanation: Improves diagnostic messages for duplicate product/target to include involved packages and other useful information. - Scope: Package manifests/graphs with duplicate product/target names. - Main Branch PRs: #7572 - Resolves: rdar://127623219 - Risk: Very Low - Reviewed By: @xedin - Testing: New tests were added to the suite and existing tests updated. (cherry picked from commit e5123e4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rdar://127623219