[6.0] Pass through experimental swift-testing flags #7564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st` (#7534) This PR adds two undocumented/unsupported experimental options to `swift test` to allow passing through JSON files/streams for input and output. These streams are still under development in swift-testing, so these options are not yet supported, but this change will allow interested coders to experiment with them. --------- Co-authored-by: Max Desiatov <m_desiatov@apple.com>
…7551) Follow-on to #7534. swift-testing has an additional argument specifying the schema version of the JSON being used that we also need to pass through SwiftPM. See: swiftlang/swift-testing#383
grynspan
added
enhancement
swift test
grynspan
requested review from
bnbarham,
MaxDesiatov,
jakepetroules and
francescomikulis
as code owners
|
@swift-ci please test |
bnbarham
approved these changes
May 15, 2024
grynspan
deleted the
jgrynspan/pass-through-experimental-swift-testing-flags-6.0
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Pass through
--experimental-configuration-path,--experimental-event-stream-output, and--experimental-event-stream-versionas used by swift-testing. These flags are needed for continued experimental support of swift-testing when using the Swift 6 toolchain.Scope: Hidden flags in
swift test.Original PR: #7534, #7551
Risk: No obvious risk. These flags have no effect on
swift testitself and are simply passed through verbatim to the swift-testing test executable.Testing: Tested at-desk that the flags are seen by swift-testing with an appropriate toolchain.
Reviewer: @bnbarham, @MaxDesiatov, @stmontgomery