Expose the build triple of a BuildTarget in SourceKitLSPAPI
#7555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
commented
May 13, 2024
| @@ -23,13 +23,16 @@ import class Build.ClangTargetBuildDescription | |||
| import class Build.SwiftTargetBuildDescription | |||
| import struct PackageGraph.ResolvedModule | |||
| import struct PackageGraph.ModulesGraph | |||
| import enum PackageGraph.BuildTriple | |||
There was a problem hiding this comment.
@MaxDesiatov Do you prefer to expose the BuildTriple type or would you prefer to define an equivalent BuildTriple type in SourceKitLSPAPI and then map between the two?
There was a problem hiding this comment.
For now IMO it's best to create public typealias BuildTriple = PackageGraph.BuildTriple in SourceKitLSPAPI, which can be replaced with something more advanced later.
ahoppen
force-pushed
the
expose-build-triple
branch
from
1974b4e to
6b23a47
Compare
|
@swift-ci Please test |
bnbarham
approved these changes
May 14, 2024
furby-tm
pushed a commit
to wabiverse/swift-package-manager
that referenced
this pull request
May 15, 2024
…tlang#7555) If we have a package like this ```swift let package = Package( name: "MyLibrary", targets: [ .target(name: "Lib"), .executableTarget(name: "MyExec", dependencies: ["Lib"]), .plugin( name: "MyPlugin", capability: .command( intent: .sourceCodeFormatting(), permissions: [] ), dependencies: ["MyExec"] ) ] ) ``` Then the package graph contains two targets for `Lib`. We need to be able to differentiate them in SourceKit-LSP. For that, we need to expose the build triple of a `BuildTarget`.
ahoppen
added a commit
that referenced
this pull request
May 15, 2024
- **Explanation**: Adds a couple of APIs to the `SourceKitLSPAPI` module that are needed for background indexing in SourceKit-LSP - **Scope**: Purely additive API - **Risk**: Very low, just adds new API - **Testing**: n/a - **Issue**: n/a - **Reviewer**: @MaxDesiatov and @bnbarham on #7540 #7555 respectively
furby-tm
pushed a commit
to wabiverse/swift-package-manager
that referenced
this pull request
May 15, 2024
…tlang#7555) If we have a package like this ```swift let package = Package( name: "MyLibrary", targets: [ .target(name: "Lib"), .executableTarget(name: "MyExec", dependencies: ["Lib"]), .plugin( name: "MyPlugin", capability: .command( intent: .sourceCodeFormatting(), permissions: [] ), dependencies: ["MyExec"] ) ] ) ``` Then the package graph contains two targets for `Lib`. We need to be able to differentiate them in SourceKit-LSP. For that, we need to expose the build triple of a `BuildTarget`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we have a package like this
Then the package graph contains two targets for
Lib. We need to be able to differentiate them in SourceKit-LSP. For that, we need to expose the build triple of aBuildTarget.