Add API for background preparation in SourceKit-LSP #7540
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ahoppen
commented
May 8, 2024
ahoppen
commented
- Add an API to get the name of a target from SourceKit-LSP
- We will need this API to prepare a target for indexing.
- Add an API to get all the targets in a build description / modules graph in a topological order
- We need this for background preparation for indexing so that we can prepare and index lower-level targets first.
We will need this API to prepare a target for indexing.
…aph in a topological order We need this for background preparation for indexing so that we can prepare and index lower-level targets first.
|
@swift-ci Please test |
MaxDesiatov
approved these changes
May 9, 2024
furby-tm
pushed a commit
to wabiverse/swift-package-manager
that referenced
this pull request
May 15, 2024
- Add an API to get the name of a target from SourceKit-LSP - We will need this API to prepare a target for indexing. - Add an API to get all the targets in a build description / modules graph in a topological order - We need this for background preparation for indexing so that we can prepare and index lower-level targets first.
ahoppen
added a commit
that referenced
this pull request
May 15, 2024
- **Explanation**: Adds a couple of APIs to the `SourceKitLSPAPI` module that are needed for background indexing in SourceKit-LSP - **Scope**: Purely additive API - **Risk**: Very low, just adds new API - **Testing**: n/a - **Issue**: n/a - **Reviewer**: @MaxDesiatov and @bnbarham on #7540 #7555 respectively
furby-tm
pushed a commit
to wabiverse/swift-package-manager
that referenced
this pull request
May 15, 2024
- Add an API to get the name of a target from SourceKit-LSP - We will need this API to prepare a target for indexing. - Add an API to get all the targets in a build description / modules graph in a topological order - We need this for background preparation for indexing so that we can prepare and index lower-level targets first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.