Enable strict concurrency checks on Basics module
#7451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also refactored `URLSessionHTTPClient` to remove `weak` references, which were incompatible with strict concurrency checks.
|
@swift-ci test |
…xd/basics-strict-concurrency # Conflicts: # Package.swift
|
@swift-ci test |
xedin
approved these changes
Apr 15, 2024
|
@swift-ci test windows |
|
@swift-ci test |
|
@swift-ci test windows |
furby-tm
pushed a commit
to wabiverse/swift-package-manager
that referenced
this pull request
May 15, 2024
Also refactored `URLSessionHTTPClient` to remove `weak` references, which were incompatible with strict concurrency checks.
furby-tm
pushed a commit
to wabiverse/swift-package-manager
that referenced
this pull request
May 15, 2024
Also refactored `URLSessionHTTPClient` to remove `weak` references, which were incompatible with strict concurrency checks.
bnbarham
pushed a commit
to bnbarham/swift-package-manager
that referenced
this pull request
May 18, 2024
Also refactored `URLSessionHTTPClient` to remove `weak` references, which were incompatible with strict concurrency checks. (cherry picked from commit f249153)
bnbarham
added a commit
to bnbarham/swift-package-manager
that referenced
this pull request
May 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also refactored
URLSessionHTTPClientto removeweakreferences, which were incompatible with strict concurrency checks.