Skip to content

[chore] Update Package.swift in Examples/package-info #7420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

coffmark
Copy link
Contributor

@coffmark coffmark commented Mar 25, 2024

Update Package.swift in Examples/package-info.

Motivation:

I couldn't build Examples/package-info in Venture(v13.6.2).
This is because the minimum supported version of Examples/package-info is lower than the minimum supported version of swift-package-manager.

Modifications:

I have corrected the minimum supported version of Examples/package-info to be the same as the minimum supported version of swift-package-manager. (Package.swift in swift-pacakge-manger)

Result:

Examples/package-info can be built.

@coffmark
Copy link
Contributor Author

@swift-ci test

@coffmark coffmark force-pushed the chore/update-package-in-example branch from 53c74a1 to 057c04e Compare March 27, 2024 00:33
@kateinoigakukun
Copy link
Member

@swift-ci test

@kateinoigakukun
Copy link
Member

@swift-ci test Windows platform

1 similar comment
@kateinoigakukun
Copy link
Member

@swift-ci test Windows platform

@MaxDesiatov
Copy link
Contributor

This example package is outdated and was created back when SwiftPM was considering semver for its own package versioning. This is no longer the case, we're not committing to a stable API outside of PackageDescription and PackagePlugin modules. IMO this example package should be deleted to avoid potential confusion, otherwise it's misleading people to believe there is a stable versioned API.

@bnbarham WDYT?

@bnbarham
Copy link
Contributor

bnbarham commented Apr 1, 2024

IMO this example package should be deleted to avoid potential confusion, otherwise it's misleading people to believe there is a stable versioned API.

That or changing the comment to specifically point out that the API is unstable. Either works for me.

@MaxDesiatov
Copy link
Contributor

Closing this as superseded by #7434.

@MaxDesiatov MaxDesiatov closed this Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants