Hide CLI commands API with package access control
#7381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To prevent accidental adoption of these APIs as `public`, we should use `package` access control instead. Also replaced remaining usages of `@_spi(SwiftPMInternal)` with `package` across all of our codebase.
|
@swift-ci test |
bnbarham
approved these changes
Feb 29, 2024
furby-tm
pushed a commit
to wabiverse/swift-package-manager
that referenced
this pull request
May 15, 2024
Known clients of SwiftPM have not adopted these CLI APIs that were previously marked as `public`. To prevent accidental adoption by clients in the future, we should use `package` access control instead. Also replaced remaining usages of `@_spi(SwiftPMInternal)` with `package` across all of our codebase.
furby-tm
pushed a commit
to wabiverse/swift-package-manager
that referenced
this pull request
May 15, 2024
Known clients of SwiftPM have not adopted these CLI APIs that were previously marked as `public`. To prevent accidental adoption by clients in the future, we should use `package` access control instead. Also replaced remaining usages of `@_spi(SwiftPMInternal)` with `package` across all of our codebase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Known clients of SwiftPM have not adopted these CLI APIs that were previously marked as
public. To prevent accidental adoption by clients in the future, we should usepackageaccess control instead.Also replaced remaining usages of
@_spi(SwiftPMInternal)withpackageacross all of our codebase.