Hide build system internals with @_spi
#7365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These details should not leak outside of the SwiftPM package. In the (hopefully temporary) absence of `package` access control, we can hide build system-related APIs with `@_spi` annotations.
MaxDesiatov
added
the
no functional change
|
@swift-ci test |
|
@swift-ci test |
MaxDesiatov
added
build system
|
@swift-ci test |
|
@swift-ci test windows |
|
@swift-ci test macos |
…xd/spi-build-system # Conflicts: # Sources/Commands/SwiftBuildCommand.swift # Sources/Commands/SwiftRunCommand.swift # Sources/Commands/SwiftTestCommand.swift # Sources/CoreCommands/BuildSystemSupport.swift # Sources/CoreCommands/SwiftCommandState.swift # Sources/swift-package-manager/SwiftPM.swift
|
@swift-ci test |
|
@swift-ci test windows |
…xd/spi-build-system # Conflicts: # Sources/Commands/SwiftBuildCommand.swift # Sources/Commands/SwiftRunCommand.swift
|
@swift-ci test |
|
@swift-ci test windows |
bnbarham
approved these changes
Feb 26, 2024
| @testable import CoreCommands | ||
|
|
||
| @_spi(SwiftPMInternal) | ||
| @testable |
There was a problem hiding this comment.
Would be nice to remove all our @testable too IMO (to avoid the rebuild) and use SPI instead.
There was a problem hiding this comment.
Kind of weird that @testable doesn't automagically work like @_spi and requires rebuilding stuff, isn't it?
|
@swift-ci test |
|
@swift-ci test |
|
@swift-ci test windows |
furby-tm
pushed a commit
to wabiverse/swift-package-manager
that referenced
this pull request
May 15, 2024
These details should not leak outside of the SwiftPM package. In the (hopefully temporary) absence of `package` access control, we can hide build system-related APIs with `@_spi` annotations.
furby-tm
pushed a commit
to wabiverse/swift-package-manager
that referenced
this pull request
May 15, 2024
These details should not leak outside of the SwiftPM package. In the (hopefully temporary) absence of `package` access control, we can hide build system-related APIs with `@_spi` annotations.
xedin
added a commit
to xedin/swift-package-manager
that referenced
this pull request
May 15, 2024
This reverts commit 92d65bf.
xedin
added a commit
to xedin/swift-package-manager
that referenced
this pull request
May 15, 2024
This reverts commit 92d65bf.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These details should not leak outside of the SwiftPM package. In the (hopefully temporary) absence of
packageaccess control, we can hide build system-related APIs with@_spiannotations.