Rename Swift*Tool to Swift*Command
#7336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an existing point of confusion, where `SwiftBuildTool` that handles `swift build` CLI invocations could be misunderstood as something responsible for build tools in plugins, which becomes especially apparent when working on the plugins codebase. Additionally, `SwiftTool` is a grab bag reference type for storing state injected into a CLI command, so we should rename it to `SwiftCommandState` for clarity.
MaxDesiatov
added
plugins
no functional change
MaxDesiatov
requested review from
bnbarham,
neonichu and
tomerd
as code owners
|
@swift-ci test |
…xd/your-tool-is-my-command # Conflicts: # Sources/Commands/PackageCommands/EditCommands.swift # Sources/CoreCommands/BuildSystemSupport.swift # Sources/CoreCommands/SwiftCommandObservabilityHandler.swift # Sources/PackageRegistryCommand/PackageRegistryCommand.swift # Tests/CommandsTests/PackageRegistryCommandTests.swift
|
@swift-ci test |
…xd/your-tool-is-my-command # Conflicts: # Sources/Commands/PackageCommands/DumpCommands.swift
|
@swift-ci test |
bnbarham
approved these changes
Feb 23, 2024
…xd/your-tool-is-my-command
|
@swift-ci test |
|
@swift-ci test windows |
…xd/your-tool-is-my-command
|
@swift-ci test |
|
@swift-ci test windows |
|
@swift-ci clean test windows |
|
@swift-ci test windows |
1 similar comment
|
@swift-ci test windows |
|
@swift-ci test windows |
|
@swift-ci test |
|
@swift-ci test windows |
furby-tm
pushed a commit
to wabiverse/swift-package-manager
that referenced
this pull request
May 15, 2024
This removes an existing point of confusion, where `SwiftBuildTool` that handles `swift build` CLI invocations could be misunderstood as something responsible for build tools in plugins. It becomes especially problematic when working on the plugins codebase. Additionally, `SwiftTool` is a grab bag reference type for storing state injected into a CLI command, so we should rename it to `SwiftCommandState` for clarity.
furby-tm
pushed a commit
to wabiverse/swift-package-manager
that referenced
this pull request
May 15, 2024
This removes an existing point of confusion, where `SwiftBuildTool` that handles `swift build` CLI invocations could be misunderstood as something responsible for build tools in plugins. It becomes especially problematic when working on the plugins codebase. Additionally, `SwiftTool` is a grab bag reference type for storing state injected into a CLI command, so we should rename it to `SwiftCommandState` for clarity.
kateinoigakukun
added a commit
to kateinoigakukun/swift-package-manager
that referenced
this pull request
May 28, 2024
The subcommand seems accidentally renamed to `swift package completion-command` while renaming the type name in swiftlang#7336 This change renames it back to `swift package completion-tool` keep compatibility with the previous version.
kateinoigakukun
added a commit
to kateinoigakukun/swift-package-manager
that referenced
this pull request
May 28, 2024
The subcommand seems accidentally renamed to `swift package completion-command` while renaming the type name in swiftlang#7336 This change renames it back to `swift package completion-tool` keep compatibility with the previous version.
kateinoigakukun
added a commit
to kateinoigakukun/swift-package-manager
that referenced
this pull request
May 28, 2024
The subcommand seems accidentally renamed to `swift package completion-command` while renaming the type name in swiftlang#7336 This change renames it back to `swift package completion-tool` keep compatibility with the previous version.
kateinoigakukun
added a commit
to kateinoigakukun/swift-package-manager
that referenced
this pull request
May 28, 2024
The subcommand seems accidentally renamed to `swift package completion-command` while renaming the type name in swiftlang#7336 This change renames it back to `swift package completion-tool` keep compatibility with the previous version.
MaxDesiatov
pushed a commit
that referenced
this pull request
May 28, 2024
Rename `swift package completion-command` back to `swift package completion-tool`. ### Motivation: The subcommand seems accidentally renamed to `swift package completion-command` while renaming the type name in #7336 ### Modifications: This change renames it back to `swift package completion-tool` to keep compatibility with the previous version. This should be cherry-picked to release/6.0 too. ### Result: Keep command name compatibility
bnbarham
pushed a commit
that referenced
this pull request
May 28, 2024
The subcommand seems accidentally renamed to `swift package completion-command` while renaming the type name in #7336 This change renames it back to `swift package completion-tool` keep compatibility with the previous version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes an existing point of confusion, where
SwiftBuildToolthat handlesswift buildCLI invocations could be misunderstood as something responsible for build tools in plugins. It becomes especially problematic when working on the plugins codebase.Additionally,
SwiftToolis a grab bag reference type for storing state injected into a CLI command, so we should rename it toSwiftCommandStatefor clarity.