Skip to content

DNM/WIP: support libraries in .artifactbundles #6967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

DNM/WIP: support libraries in .artifactbundles #6967

wants to merge 7 commits into from

Conversation

MaxDesiatov
Copy link
Contributor

@MaxDesiatov MaxDesiatov commented Oct 3, 2023 •
edited
Loading

@MaxDesiatov MaxDesiatov added the WIP Work in progress label Oct 3, 2023
@MaxDesiatov MaxDesiatov self-assigned this Oct 4, 2023
@MaxDesiatov MaxDesiatov mentioned this pull request Oct 30, 2023
Closed
@MaxDesiatov MaxDesiatov mentioned this pull request Jan 10, 2024
Closed
@terraputix terraputix mentioned this pull request Oct 22, 2024
Closed
@MaxDesiatov
Copy link
Contributor Author

Closing as outdated due to accumulated conflicts and necessary prerequisites as described in the corresponding issue not currently implemented.

@MaxDesiatov MaxDesiatov closed this Jan 8, 2025
@MaxDesiatov MaxDesiatov deleted the maxd/library-artifact-bundle branch January 8, 2025 11:25
@MaxDesiatov MaxDesiatov restored the maxd/library-artifact-bundle branch March 3, 2025 12:15
@MaxDesiatov MaxDesiatov reopened this Mar 18, 2025
@jakepetroules
Copy link
Contributor

Before this lands, please make sure to open a corresponding PR against Swift Build to ensure this functionality works when using the Swift Build backend as well.

@MaxDesiatov
Merge branch 'main' of https://github.com/swiftlang/swift-package-man…
b72350e 
…ager into maxd/library-artifact-bundle

# Conflicts:
#	Sources/Build/BuildPlan.swift
#	Sources/PackageModel/ArtifactsArchiveMetadata.swift
#	Sources/SPMBuildCore/Plugins/PluginInvocation.swift
@MaxDesiatov
Fix build errors after conflict resolution
447a1b3
@MaxDesiatov
Copy link
Contributor Author

@swift-ci test

MaxDesiatov
MaxDesiatov commented Apr 17, 2025
View reviewed changes
MaxDesiatov
MaxDesiatov commented Apr 17, 2025
View reviewed changes
MaxDesiatov
MaxDesiatov commented Apr 17, 2025
View reviewed changes
@MaxDesiatov MaxDesiatov added needs tests This change needs test coverage and removed WIP Work in progress labels Apr 17, 2025
@MaxDesiatov
Copy link
Contributor Author

@swift-ci test

1 similar comment
@MaxDesiatov
Copy link
Contributor Author

@swift-ci test

@daniel-grumberg daniel-grumberg mentioned this pull request May 2, 2025
Merged
@MaxDesiatov
Copy link
Contributor Author

Closing in favor of #8639

@MaxDesiatov MaxDesiatov closed this Jun 6, 2025
@MaxDesiatov MaxDesiatov deleted the maxd/library-artifact-bundle branch June 6, 2025 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakepetroules jakepetroules Awaiting requested review from jakepetroules jakepetroules will be requested when the pull request is marked ready for review jakepetroules is a code owner

@dschaefer2 dschaefer2 Awaiting requested review from dschaefer2 dschaefer2 will be requested when the pull request is marked ready for review dschaefer2 is a code owner

@shawnhyam shawnhyam Awaiting requested review from shawnhyam shawnhyam will be requested when the pull request is marked ready for review shawnhyam is a code owner

@bripeticca bripeticca Awaiting requested review from bripeticca bripeticca will be requested when the pull request is marked ready for review bripeticca is a code owner

@plemarquand plemarquand Awaiting requested review from plemarquand plemarquand will be requested when the pull request is marked ready for review plemarquand is a code owner

@owenv owenv Awaiting requested review from owenv owenv will be requested when the pull request is marked ready for review owenv is a code owner

@bkhouri bkhouri Awaiting requested review from bkhouri bkhouri will be requested when the pull request is marked ready for review bkhouri is a code owner

@cmcgee1024 cmcgee1024 Awaiting requested review from cmcgee1024 cmcgee1024 will be requested when the pull request is marked ready for review cmcgee1024 is a code owner

@daveyc123 daveyc123 Awaiting requested review from daveyc123 daveyc123 will be requested when the pull request is marked ready for review daveyc123 is a code owner

Assignees

@MaxDesiatov MaxDesiatov

Labels
needs tests This change needs test coverage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaxDesiatov @jakepetroules