Remove <toolchain>/usr/bin/../lib/ from directories passed to linker to look up libraries for target triple #6824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to look up libraries for target triple Also, update my github username in the mailmap. Resolves swiftlang#6767
finagolfin
requested review from
abertelrud,
neonichu,
tomerd and
MaxDesiatov
as code owners
neonichu
approved these changes
Aug 17, 2023
|
@swift-ci please smoke test |
|
Timeout on Windows CI when running the foundation tests is unrelated. |
|
@swift-ci please smoke test windows |
|
Ping, ready to go in, I'll submit for 5.9 next. |
etcwilde
approved these changes
Aug 22, 2023
finagolfin
added a commit
to finagolfin/swift-package-manager
that referenced
this pull request
Aug 22, 2023
…to look up libraries for target triple (swiftlang#6824) Also, update my github username in the mailmap. Resolves swiftlang#6767
finagolfin
added a commit
to finagolfin/swift-package-manager
that referenced
this pull request
Aug 23, 2023
…to look up libraries for target triple (swiftlang#6824) Also, update my github username in the mailmap. Resolves swiftlang#6767
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, update my github username in the mailmap.
Resolves #6767
@neonichu, let me know what you think.