[5.9.0] Remove extra paths added to LD_LIBRARY_PATH on Linux when running tests #6822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These break running tests when there's already a swift on PATH that isn't the swift currently being run. There shouldn't be a need for these as the run path of the compiled binary is already the correct path (ie. the library path of the swift that built it and `$ORIGIN`). (cherry picked from commit 5c7db58) (cherry picked from commit 07952dc)
Note that in the 5.9 cherry-pick @neonichu mentioned:
So I did additionally test that the toolchain with this change is still able to |
|
@swift-ci please smoke test |
DougGregor
approved these changes
Aug 16, 2023
neonichu
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
swift teston Linux platformsswift testworks on a SwiftPM project using a toolchain with this change.