Refactor registry checksum TOFU logic #6190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Checksum TOFU logic is scattered in `RegistryClient`, making it difficult to reason about and maintain. Modifications: Refactor checksum TOFU logic into `PackageVersionChecksumTOFU`.
yim-lee
requested review from
abertelrud,
neonichu and
tomerd
as code owners
|
@swift-ci please smoke test |
tomerd
reviewed
Feb 27, 2023
| self.registryClient = registryClient | ||
| } | ||
|
|
||
| func check( |
There was a problem hiding this comment.
nit: validate probable a better fit?
There was a problem hiding this comment.
I will rename it as part of #6184
neonichu
approved these changes
Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Checksum TOFU logic is scattered in
RegistryClient, making it difficult to reason about and maintain.Modifications:
Refactor checksum TOFU logic into
PackageVersionChecksumTOFU.