Add an environment check to opt in for API diff functionality tests #3697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elsh
requested review from
abertelrud,
friedbunny,
neonichu and
tomerd
as code owners
|
@swift-ci smoke test |
tomerd
approved these changes
Aug 31, 2021
|
thanks @elsh |
yyvch
added a commit
to yyvch/swift-package-manager
that referenced
this pull request
Jan 4, 2025
Since swiftlang#3697 the APIDiff tests were opt-in which set expectation that the tests should skip by default. This change makes the APIDiff tests to run by default so then we could rely on CI status and assurance of test coverage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Output of the API diff digester can be different per platform, which should be addressed at the functionality level, as long as the invocation is successful. This separates out the integration point testing of the diff digester and SwiftPM from the functionality tests of the digester itself.