[Collections] Signing (apple, 4): signature validation #3271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yim-lee
requested review from
abertelrud,
friedbunny,
neonichu and
tomerd
as code owners
This was referenced Feb 13, 2021
tomerd
reviewed
Feb 15, 2021
Sources/PackageCollections/Providers/JSONPackageCollectionProvider.swift
Outdated
Show resolved
Hide resolved
tomerd
approved these changes
Feb 15, 2021
|
cc @catmurdoch |
tomerd
added
the
ready
yim-lee
force-pushed
the
wire-signing-ap
branch
from
8556deb to
d406b49
Compare
yim-lee
commented
Feb 17, 2021
Sources/PackageCollections/Signature/PackageCollection+CertificatePolicy.swift
Outdated
Show resolved
Hide resolved
yim-lee
force-pushed
the
wire-signing-ap
branch
from
6a76ca7 to
8a04c8d
Compare
tomerd
reviewed
Feb 18, 2021
Sources/PackageCollections/Providers/JSONPackageCollectionProvider.swift
Outdated
Show resolved
Hide resolved
tomerd
reviewed
Feb 18, 2021
Sources/PackageCollectionsSigning/PackageCollectionSigning.swift
Outdated
Show resolved
Hide resolved
yim-lee
force-pushed
the
wire-signing-ap
branch
from
8a04c8d to
0628174
Compare
This is part 4 of a series of PRs to support package collection signing on **Apple** platforms. Originally swiftlang#3252. Depends on swiftlang#3269. Modifications: - Add `PackageCollectionsSigning` dependency to `PackageCollections` module - Verify collection signature in `JSONPackageCollectionProvider`
yim-lee
force-pushed
the
wire-signing-ap
branch
from
0628174 to
e521d0c
Compare
yim-lee
force-pushed
the
wire-signing-ap
branch
from
e521d0c to
49db56a
Compare
yim-lee
force-pushed
the
wire-signing-ap
branch
from
c29b9a2 to
c1df354
Compare
tomerd
reviewed
Feb 19, 2021
Sources/PackageCollections/Providers/JSONPackageCollectionProvider.swift
Outdated
Show resolved
Hide resolved
tomerd
approved these changes
Feb 19, 2021
|
yim-lee:wire-signing-ap |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part 4 of a series of PRs to support package collection signing on Apple platforms. Originally #3252.
Depends on #3269.
Modifications:
PackageCollectionsSigningdependency toPackageCollectionsmoduleJSONPackageCollectionProvider