[Collections] Signing (part 5): validate signature #3252
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is part 1 of a series of PRs to support package collection signing. Modifications: - New `PackageCollectionsSigning` module - Add `Certificate` type - Add EC and RSA key types
Following example apple/swift-crypto#67
This is part 2 of a series of PRs to support package collection signing. Depends on [part 1](swiftlang#3241) Modifications: Add support for signing with EC and RSA keys
- Introduce `CertificatePolicy` protocol (more on this in part 3) - `PackageCollectionsSigning` - given a package collection, certificate and its private key, generate a "signed" collection; and reverse that process to validate collection signature.
This is part 3 of a series of PRs to support package collection signing. Depends on [part 2](swiftlang#3242) Modifications: - Certificate policies to validate collection signing certificates. OCSP support on non-Apple platforms to come in part 4. - Wire up `PackageCollectionSigning` with certificate policies.
This is part 4 of a series of PRs to support package collection signing. Depends on [part 3](swiftlang#3245) Modifications: - Add PackageCollectionsSigningLibc module - Add OCSP support for non-Apple platforms through PackageCollectionsSigningLibc
This continues [part 4](swiftlang#3250) but doesn't necessarily depend on it. Modifications: - Add `PackageCollectionsSigning` dependency to `PackageCollections` module - Verify collection signature in `JSONPackageCollectionProvider`
yim-lee
requested review from
abertelrud,
friedbunny,
neonichu and
tomerd
as code owners
|
@swift-ci please smoke test |
tomerd
reviewed
Feb 10, 2021
| certChainPaths: [URL], | ||
| certPrivateKeyPath: URL, | ||
| certPolicyKey: CertificatePolicyKey, | ||
| jsonEncoder: JSONEncoder, |
There was a problem hiding this comment.
question: are we passing a concrete JSONEncoder to save the need to create a new one every time?
There was a problem hiding this comment.
are we passing a concrete JSONEncoder to save the need to create a new one every time?
No, the collection is serialized and embedded inside the signature, and upon checking the signature we deserialize the collection and compare it with the one received. In previous implementations we were comparing JSON/Data so we had to make sure we use the same encoder/decoder, but now that we are comparing SignedCollection we can probably get away with that.
tomerd
reviewed
Feb 10, 2021
| /// - callback: The callback to invoke when the result is available. | ||
| func validate(signedCollection: PackageCollectionModel.V1.SignedCollection, | ||
| certPolicyKey: CertificatePolicyKey, | ||
| jsonDecoder: JSONDecoder, |
There was a problem hiding this comment.
same question as above. seems a bit unnatural to have it in the public API vs. a private static decoder/encoder at the implementation level (imo). fwiw, I would feel differently if this was a "TopLevelEncoder" (which does not exist in the stdlib) that reflect the format can be either JSON or something else, but since its always JSON it feels like this should be an impl detail rather than exposed in the API
yim-lee
added a commit
to yim-lee/swift-package-manager
that referenced
this pull request
Feb 13, 2021
This is part 4 of a series of PRs to support package collection signing on Apple platforms. Originally swiftlang#3252. Depends on swiftlang#3269. Modifications: - Add `PackageCollectionsSigning` dependency to `PackageCollections` module - Verify collection signature in `JSONPackageCollectionProvider`
yim-lee
added a commit
to yim-lee/swift-package-manager
that referenced
this pull request
Feb 13, 2021
This is part 4 of a series of PRs to support package collection signing on Apple platforms. Originally swiftlang#3252. Depends on swiftlang#3269. Modifications: - Add `PackageCollectionsSigning` dependency to `PackageCollections` module - Verify collection signature in `JSONPackageCollectionProvider`
yim-lee
added a commit
to yim-lee/swift-package-manager
that referenced
this pull request
Feb 17, 2021
This is part 4 of a series of PRs to support package collection signing on Apple platforms. Originally swiftlang#3252. Depends on swiftlang#3269. Modifications: - Add `PackageCollectionsSigning` dependency to `PackageCollections` module - Verify collection signature in `JSONPackageCollectionProvider`
yim-lee
added a commit
to yim-lee/swift-package-manager
that referenced
this pull request
Feb 18, 2021
This is part 4 of a series of PRs to support package collection signing on **Apple** platforms. Originally swiftlang#3252. Depends on swiftlang#3269. Modifications: - Add `PackageCollectionsSigning` dependency to `PackageCollections` module - Verify collection signature in `JSONPackageCollectionProvider`
yim-lee
added a commit
to yim-lee/swift-package-manager
that referenced
this pull request
Feb 18, 2021
This is part 4 of a series of PRs to support package collection signing on **Apple** platforms. Originally swiftlang#3252. Depends on swiftlang#3269. Modifications: - Add `PackageCollectionsSigning` dependency to `PackageCollections` module - Verify collection signature in `JSONPackageCollectionProvider`
yim-lee
added a commit
to yim-lee/swift-package-manager
that referenced
this pull request
Feb 18, 2021
This is part 4 of a series of PRs to support package collection signing on **Apple** platforms. Originally swiftlang#3252. Depends on swiftlang#3269. Modifications: - Add `PackageCollectionsSigning` dependency to `PackageCollections` module - Verify collection signature in `JSONPackageCollectionProvider`
yim-lee
added a commit
that referenced
this pull request
Feb 19, 2021
This is part 4 of a series of PRs to support package collection signing on **Apple** platforms. Originally #3252. Depends on #3269. Modifications: - Add `PackageCollectionsSigning` dependency to `PackageCollections` module - Verify collection signature in `JSONPackageCollectionProvider` - Don't cache CertificatePolicy - Add support for additionalTrustedRootCerts - Custom certificate policy by collection source - Throw cannotVerifySignature when no trusted roots configured - Feature flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This continues part 4 but doesn't necessarily depend on it.
Modifications:
PackageCollectionsSigningdependency toPackageCollectionsmoduleJSONPackageCollectionProvider