[Collections] Signing (part 3): certificate validations #3245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yim-lee
requested review from
abertelrud,
friedbunny,
neonichu and
tomerd
as code owners
tomerd
reviewed
Feb 8, 2021
Sources/PackageCollectionsSigning/PackageCollectionSigning.swift
Outdated
Show resolved
Hide resolved
tomerd
reviewed
Feb 8, 2021
| /// - expectedSubjectUserID: The subject user ID that must match if specified. | ||
| /// - queue: The `DispatchQueue` to perform async operations. | ||
| init(trustedRootCertsDir: URL? = nil, expectedSubjectUserID: String? = nil, queue: DispatchQueue = DispatchQueue.global()) { | ||
| self.trustedRoots = trustedRootCertsDir.map { Self.loadCerts(at: $0) } |
There was a problem hiding this comment.
is loading them quick? otherwise maybe you can load and cache in "validate" sync its async anyways?
tomerd
reviewed
Feb 8, 2021
Sources/PackageCollectionsSigning/Certificate/CertificatePolicy.swift
Outdated
Show resolved
Hide resolved
tomerd
reviewed
Feb 8, 2021
yim-lee
force-pushed
the
certificate-policy
branch
from
9437c33 to
9a4dbaa
Compare
yim-lee
added a commit
to yim-lee/swift-package-manager
that referenced
this pull request
Feb 9, 2021
This is part 4 of a series of PRs to support package collection signing. Depends on [part 3](swiftlang#3245) Modifications: - Add PackageCollectionsSigningLibc module - Add OCSP support for non-Apple platforms through PackageCollectionsSigningLibc
|
This is ready for review. The relevant commits are
cc @Lukasa @FredericJacobs @catmurdoch PTAL. Thanks. |
This is part 1 of a series of PRs to support package collection signing. Modifications: - New `PackageCollectionsSigning` module - Add `Certificate` type - Add EC and RSA key types
Following example apple/swift-crypto#67
This is part 2 of a series of PRs to support package collection signing. Depends on [part 1](swiftlang#3241) Modifications: Add support for signing with EC and RSA keys
- Introduce `CertificatePolicy` protocol (more on this in part 3) - `PackageCollectionsSigning` - given a package collection, certificate and its private key, generate a "signed" collection; and reverse that process to validate collection signature.
yim-lee
force-pushed
the
certificate-policy
branch
from
9a4dbaa to
bc65b93
Compare
This is part 3 of a series of PRs to support package collection signing. Depends on [part 2](swiftlang#3242) Modifications: - Certificate policies to validate collection signing certificates. OCSP support on non-Apple platforms to come in part 4. - Wire up `PackageCollectionSigning` with certificate policies.
yim-lee
force-pushed
the
certificate-policy
branch
from
bc65b93 to
797f13e
Compare
yim-lee
added a commit
to yim-lee/swift-package-manager
that referenced
this pull request
Feb 13, 2021
This is part 3 of a series of PRs to support package collection signing on **Apple** platforms. Originally swiftlang#3245. Depends on swiftlang#3264 Modifications: - Add certificate policies to validate collection-signing certificates. - Wire up `PackageCollectionSigning` with certificate policies.
yim-lee
added a commit
to yim-lee/swift-package-manager
that referenced
this pull request
Feb 13, 2021
This is part 3 of a series of PRs to support package collection signing on **Apple** platforms. Originally swiftlang#3245. Depends on swiftlang#3264 Modifications: - Add certificate policies to validate collection-signing certificates. - Wire up `PackageCollectionSigning` with certificate policies.
yim-lee
added a commit
to yim-lee/swift-package-manager
that referenced
this pull request
Feb 13, 2021
This is part 3 of a series of PRs to support package collection signing on **non-Apple** platforms. Originally swiftlang#3245. Depends on swiftlang#3265, swiftlang#3269
yim-lee
added a commit
to yim-lee/swift-package-manager
that referenced
this pull request
Feb 13, 2021
This is part 3 of a series of PRs to support package collection signing on **non-Apple** platforms. Originally swiftlang#3245. Depends on swiftlang#3265, swiftlang#3269
yim-lee
added a commit
to yim-lee/swift-package-manager
that referenced
this pull request
Feb 13, 2021
This is part 3 of a series of PRs to support package collection signing on **Apple** platforms. Originally swiftlang#3245. Depends on swiftlang#3264 Modifications: - Add certificate policies to validate collection-signing certificates. - Wire up `PackageCollectionSigning` with certificate policies.
yim-lee
added a commit
to yim-lee/swift-package-manager
that referenced
this pull request
Feb 18, 2021
This is part 3 of a series of PRs to support package collection signing on **Apple** platforms. Originally swiftlang#3245. Depends on swiftlang#3264 Modifications: - Add certificate policies to validate collection-signing certificates. - Wire up `PackageCollectionSigning` with certificate policies.
yim-lee
added a commit
to yim-lee/swift-package-manager
that referenced
this pull request
Feb 18, 2021
This is part 3 of a series of PRs to support package collection signing on **Apple** platforms. Originally swiftlang#3245. Depends on swiftlang#3264 Modifications: - Add certificate policies to validate collection-signing certificates. - Wire up `PackageCollectionSigning` with certificate policies.
yim-lee
added a commit
to yim-lee/swift-package-manager
that referenced
this pull request
Feb 18, 2021
This is part 3 of a series of PRs to support package collection signing on **all** platforms. Originally swiftlang#3245. Depends on swiftlang#3265, swiftlang#3269
yim-lee
added a commit
to yim-lee/swift-package-manager
that referenced
this pull request
Feb 18, 2021
This is part 3 of a series of PRs to support package collection signing on **all** platforms. Originally swiftlang#3245. Depends on swiftlang#3265, swiftlang#3269
yim-lee
added a commit
to yim-lee/swift-package-manager
that referenced
this pull request
Feb 18, 2021
This is part 3 of a series of PRs to support package collection signing on **all** platforms. Originally swiftlang#3245. Depends on swiftlang#3265, swiftlang#3269
yim-lee
added a commit
to yim-lee/swift-package-manager
that referenced
this pull request
Feb 20, 2021
This is part 3 of a series of PRs to support package collection signing on **all** platforms. Originally swiftlang#3245. Depends on swiftlang#3265, swiftlang#3269
yim-lee
added a commit
to yim-lee/swift-package-manager
that referenced
this pull request
Feb 22, 2021
This is part 3 of a series of PRs to support package collection signing on **all** platforms. Originally swiftlang#3245. Depends on swiftlang#3265, swiftlang#3269
yim-lee
added a commit
to yim-lee/swift-package-manager
that referenced
this pull request
Feb 26, 2021
This is part 3 of a series of PRs to support package collection signing on **all** platforms. Originally swiftlang#3245. Depends on swiftlang#3265, swiftlang#3269
yim-lee
added a commit
to yim-lee/swift-package-manager
that referenced
this pull request
Feb 26, 2021
This is part 3 of a series of PRs to support package collection signing on **all** platforms. Originally swiftlang#3245. Depends on swiftlang#3265, swiftlang#3269
yim-lee
added a commit
to yim-lee/swift-package-manager
that referenced
this pull request
Mar 2, 2021
This is part 3 of a series of PRs to support package collection signing on **all** platforms. Originally swiftlang#3245. Depends on swiftlang#3265, swiftlang#3269
yim-lee
added a commit
to yim-lee/swift-package-manager
that referenced
this pull request
Mar 9, 2021
This is part 3 of a series of PRs to support package collection signing on **all** platforms. Originally swiftlang#3245. Depends on swiftlang#3265, swiftlang#3269
yim-lee
added a commit
to yim-lee/swift-package-manager
that referenced
this pull request
Mar 10, 2021
This is part 3 of a series of PRs to support package collection signing on **all** platforms. Originally swiftlang#3245. Depends on swiftlang#3265, swiftlang#3269
yim-lee
added a commit
to yim-lee/swift-package-manager
that referenced
this pull request
Mar 11, 2021
This is part 3 of a series of PRs to support package collection signing on **all** platforms. Originally swiftlang#3245. Depends on swiftlang#3265, swiftlang#3269
yim-lee
added a commit
to yim-lee/swift-package-manager
that referenced
this pull request
Mar 11, 2021
This is part 3 of a series of PRs to support package collection signing on **all** platforms. Originally swiftlang#3245. Depends on swiftlang#3265, swiftlang#3269
yim-lee
added a commit
to yim-lee/swift-package-manager
that referenced
this pull request
Mar 12, 2021
This is part 3 of a series of PRs to support package collection signing on **all** platforms. Originally swiftlang#3245. Depends on swiftlang#3265, swiftlang#3269
yim-lee
added a commit
to yim-lee/swift-package-manager
that referenced
this pull request
Mar 12, 2021
This is part 3 of a series of PRs to support package collection signing on **all** platforms. Originally swiftlang#3245. Depends on swiftlang#3265, swiftlang#3269
yim-lee
added a commit
to yim-lee/swift-package-manager
that referenced
this pull request
Mar 13, 2021
This is part 3 of a series of PRs to support package collection signing on **all** platforms. Originally swiftlang#3245. Depends on swiftlang#3265, swiftlang#3269
yim-lee
added a commit
to yim-lee/swift-package-manager
that referenced
this pull request
Mar 20, 2021
This is part 3 of a series of PRs to support package collection signing on **all** platforms. Originally swiftlang#3245. Depends on swiftlang#3265, swiftlang#3269
yim-lee
added a commit
to yim-lee/swift-package-manager
that referenced
this pull request
Mar 22, 2021
This is part 3 of a series of PRs to support package collection signing on **all** platforms. Originally swiftlang#3245. Depends on swiftlang#3265, swiftlang#3269
yim-lee
added a commit
that referenced
this pull request
Mar 24, 2021
* [Collections] Signing (all, 1): certificate and key types This is part 1 of a series of PRs to support package collection signing on **all** platforms. Originally #3238. Depends on #3259 * [Collections] Signing (all, 2): signed collections This is part 2 of a series of PRs to support package collection signing on **all** platforms. Originally #3242. Depends on #3260, #3264 * [Collections] Signing (all, 3): certificate validations This is part 3 of a series of PRs to support package collection signing on **all** platforms. Originally #3245. Depends on #3265, #3269 * [Collections] Signing (all, 3.b): OCSP support for non-Apple platforms This is part 3.b of a series of PRs to support package collection signing on **all** platforms. Depends on #3270 Modifications: - Add `PackageCollectionsSigningLibc` module - Add OCSP support for non-Apple platforms through `PackageCollectionsSigningLibc` * Use shared callbackQueue and diagnosticsEngine in tests * Update platform check * Better OCSP error handling and cache OCSP results * Don't default to BoringSSL * OpenSSL license * fixup * Use ptr.count * Don't blindly drop X509_V_ERR_UNHANDLED_CRITICAL_EXTENSION error * Add withUnsafeMutablePointer for accessing underlying X509 pointer * Fix leaks * Use withExtendedLifetime * OSCP response handling * Delete remove from cache call * OCSP should fail open * Verify OCSP response * Create new X509_STORE per invocation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part 3 of a series of PRs to support package collection signing.
Depends on part 2
Modifications:
PackageCollectionSigningwith certificate policies.