[Collections] Signing (part 2): signed collections #3241
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is part 1 of a series of PRs to support package collection signing. Modifications: - New `PackageCollectionsSigning` module - Add `Certificate` type - Add EC and RSA key types
This is part 2 of a series of PRs to support package collection signing. [Part 1](swiftlang#3238) Modifications: - Add support for signing with EC and RSA keys - Add `Signature`, which is similar to JWS - Introduce `CertificatePolicy` protocol (more on this in part 3) - `PackageCollectionsSigning` - given a package collection, certificate and its private key, generate a "signed" collection; and reverse that process to validate collection signature.
yim-lee
requested review from
abertelrud,
friedbunny,
neonichu and
tomerd
as code owners
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
@yim-lee not sure why it failed on the smoked-test only |
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
…, Data, and [UInt8]
|
@swift-ci please smoke test |
|
I don't see which changes in this PR would cause the CI problems. Will redo it. |
yim-lee
added a commit
to yim-lee/swift-package-manager
that referenced
this pull request
Feb 7, 2021
This is part 2 of a series of PRs to support package collection signing. Depends on [part 1](swiftlang#3241 (comment)) Modifications: Add support for signing with EC and RSA keys
yim-lee
added a commit
to yim-lee/swift-package-manager
that referenced
this pull request
Feb 7, 2021
This is part 2 of a series of PRs to support package collection signing. Depends on [part 1](swiftlang#3241) Modifications: Add support for signing with EC and RSA keys
yim-lee
added a commit
to yim-lee/swift-package-manager
that referenced
this pull request
Feb 7, 2021
This is part 2 of a series of PRs to support package collection signing. Depends on [part 1](swiftlang#3241) Modifications: Add support for signing with EC and RSA keys
yim-lee
added a commit
to yim-lee/swift-package-manager
that referenced
this pull request
Feb 8, 2021
This is part 2 of a series of PRs to support package collection signing. Depends on [part 1](swiftlang#3241) Modifications: Add support for signing with EC and RSA keys
yim-lee
added a commit
to yim-lee/swift-package-manager
that referenced
this pull request
Feb 9, 2021
This is part 2 of a series of PRs to support package collection signing. Depends on [part 1](swiftlang#3241) Modifications: Add support for signing with EC and RSA keys
yim-lee
added a commit
to yim-lee/swift-package-manager
that referenced
this pull request
Feb 10, 2021
This is part 2 of a series of PRs to support package collection signing. Depends on [part 1](swiftlang#3241) Modifications: Add support for signing with EC and RSA keys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part 2 of a series of PRs to support package collection signing.
Part 1
Modifications:
Signature, which is similar to JWSCertificatePolicyprotocol (more on this in part 3)PackageCollectionsSigning- given a package collection, certificate and its private key, generate a "signed" collection; and reverse that process to validate collection signature.