Skip to content

Commit dd2309d

Browse files
committed
Add a comment to explain why we don't process code coverage on test fail.
In #6894, code coverage processing was disabled because it produces spurious output. This PR just adds a comment to the current source that links back to that one for future reference.
1 parent 5b47d46 commit dd2309d

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

Sources/Commands/SwiftTestCommand.swift

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -438,7 +438,8 @@ public struct SwiftTestCommand: AsyncSwiftCommand {
438438

439439
try await run(swiftCommandState, buildParameters: productsBuildParameters, testProducts: testProducts)
440440

441-
// process code Coverage if request
441+
// Process code coverage if requested. We do not process it if the test run failed.
442+
// See https://github.com/swiftlang/swift-package-manager/pull/6894 for more info.
442443
if self.options.enableCodeCoverage, swiftCommandState.executionStatus != .failure {
443444
try await processCodeCoverage(testProducts, swiftCommandState: swiftCommandState)
444445
}

Sources/PackageModel/WindowsToolchainInfo.swift

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -118,3 +118,7 @@ extension WindowsPlatformInfo {
118118
}
119119
}
120120
}
121+
122+
func f() {
123+
Unmanaged.passUnretained(<#T##value: _##_#>)
124+
}

0 commit comments

Comments
 (0)