[POSIX] Deprecate getenv and adopt Process.env

<rdar://problem/49197626> [POSIX] Kill getenv and adopt Process.env

Author: aciidgh

Package.swift

@@ -251,14 +251,10 @@ let package = Package(
 // package dependency like this but there is no other good way of expressing
 // this right now.
 
-#if os(Linux)
-import Glibc
-#else
-import Darwin.C
-#endif
+import class Foundation.ProcessInfo
 
-if getenv("SWIFTPM_BOOTSTRAP") == nil {
-    if getenv("SWIFTCI_USE_LOCAL_DEPS") == nil {
+if ProcessInfo.processInfo.environment["SWIFTPM_BOOTSTRAP"] == nil {
+    if ProcessInfo.processInfo.environment["SWIFTCI_USE_LOCAL_DEPS"] == nil {
         package.dependencies += [
             .package(url: "https://github.com/apple/swift-llbuild.git", .branch("master")),
         ]
@@ -272,7 +268,7 @@ if getenv("SWIFTPM_BOOTSTRAP") == nil {
     package.targets.first(where: { $0.name == "SPMLLBuild" })!.dependencies += ["llbuildSwift"]
 }
 
-if getenv("SWIFTPM_BUILD_PACKAGE_EDITOR") != nil {
+if ProcessInfo.processInfo.environment["SWIFTPM_BUILD_PACKAGE_EDITOR"] != nil {
     package.targets += [
         .target(name: "SPMPackageEditor", dependencies: ["Workspace", "SwiftSyntax"]),
         .target(name: "swiftpm-manifest-tool", dependencies: ["SPMPackageEditor"]),

Sources/Basic/Process.swift

@@ -11,7 +11,6 @@
 import class Foundation.ProcessInfo
 
 import enum POSIX.SystemError
-import func POSIX.getenv
 import SPMLibc
 import Dispatch
 
@@ -239,7 +238,7 @@ public final class Process: ObjectIdentifierProtocol {
             }
             // FIXME: This can be cached.
             let envSearchPaths = getEnvSearchPaths(
-                pathString: getenv("PATH"),
+                pathString: Process.env["PATH"],
                 currentWorkingDirectory: localFileSystem.currentWorkingDirectory
             )
             // Lookup and cache the executable path.

Sources/Basic/TemporaryFile.swift

@@ -9,7 +9,6 @@
 */
 
 import SPMLibc
-import func POSIX.getenv
 import class Foundation.FileHandle
 import class Foundation.FileManager
 
@@ -56,7 +55,7 @@ public func determineTempDirectory(_ dir: AbsolutePath? = nil) throws -> Absolut
 /// Returns temporary directory location by searching relevant env variables.
 /// Evaluates once per execution.
 private var cachedTempDirectory: AbsolutePath = {
-    return AbsolutePath(getenv("TMPDIR") ?? getenv("TEMP") ?? getenv("TMP") ?? "/tmp/")
+    return AbsolutePath(Process.env["TMPDIR"] ?? Process.env["TEMP"] ?? Process.env["TMP"] ?? "/tmp/")
 }()
 
 /// This class is basically a wrapper over posix's mkstemps() function to creates disposable files.

Sources/Basic/TerminalController.swift

@@ -9,7 +9,6 @@
 */
 
 import SPMLibc
-import func POSIX.getenv
 
 /// A class to have better control on tty output streams: standard output and standard error.
 /// Allows operations like cursor movement and colored text output on tty.
@@ -95,7 +94,7 @@ public final class TerminalController {
 
     /// Computes the terminal type of the stream.
     public static func terminalType(_ stream: LocalFileOutputByteStream) -> TerminalType {
-        if POSIX.getenv("TERM") == "dumb" {
+        if Process.env["TERM"] == "dumb" {
             return .dumb
         }
         let isTTY = isatty(fileno(stream.filePointer)) != 0
@@ -108,7 +107,7 @@ public final class TerminalController {
     /// - Returns: Current width of terminal if it was determinable.
     public static func terminalWidth() -> Int? {
         // Try to get from environment.
-        if let columns = POSIX.getenv("COLUMNS"), let width = Int(columns) {
+        if let columns = Process.env["COLUMNS"], let width = Int(columns) {
             return width
         }
 

Sources/Build/BuildPlan.swift

@@ -13,7 +13,6 @@ import SPMUtility
 import PackageModel
 import PackageGraph
 import PackageLoading
-import func POSIX.getenv
 
 public struct BuildParameters {
 
@@ -37,7 +36,7 @@ public struct BuildParameters {
         let base: AbsolutePath
         // FIXME: We use this hack to let swiftpm's functional test use shared
         // cache so it doesn't become painfully slow.
-        if getenv("IS_SWIFTPM_TEST") != nil {
+        if Process.env["IS_SWIFTPM_TEST"] != nil {
             base = BuildParameters.swiftpmTestCache
         } else {
             base = buildPath

Sources/Commands/SwiftTool.swift

@@ -825,8 +825,8 @@ private func findPackageRoot() -> AbsolutePath? {
 /// Returns the build path from the environment, if present.
 private func getEnvBuildPath(workingDir: AbsolutePath) -> AbsolutePath? {
     // Don't rely on build path from env for SwiftPM's own tests.
-    guard POSIX.getenv("IS_SWIFTPM_TEST") == nil else { return nil }
-    guard let env = POSIX.getenv("SWIFTPM_BUILD_DIR") else { return nil }
+    guard Process.env["IS_SWIFTPM_TEST"] == nil else { return nil }
+    guard let env = Process.env["SWIFTPM_BUILD_DIR"] else { return nil }
     return AbsolutePath(env, relativeTo: workingDir)
 }
 

Sources/POSIX/env.swift

@@ -13,6 +13,7 @@ import func SPMLibc.setenv
 import func SPMLibc.unsetenv
 import var SPMLibc.errno
 
+@available(*, deprecated, message: "Use Foundation.ProcessInfo instead.")
 public func getenv(_ key: String) -> String? {
     let out = SPMLibc.getenv(key)
     return out == nil ? nil : String(validatingUTF8: out!)  //FIXME locale may not be UTF8

Sources/SPMUtility/PkgConfig.swift

@@ -10,7 +10,6 @@
 
 import Basic
 import Foundation
-import func POSIX.getenv
 
 public enum PkgConfigError: Swift.Error, CustomStringConvertible {
     case couldNotFindConfigFile
@@ -173,7 +172,7 @@ public struct PkgConfig {
     }
 
     private static var envSearchPaths: [AbsolutePath] {
-        if let configPath = POSIX.getenv("PKG_CONFIG_PATH") {
+        if let configPath = Process.env["PKG_CONFIG_PATH"] {
             return configPath.split(separator: ":").map({ AbsolutePath(String($0)) })
         }
         return []

Sources/TestSupport/misc.swift

@@ -243,7 +243,7 @@ public func loadPackageGraph(
 /// - throws: errors thrown in `body`, POSIX.SystemError.setenv and
 ///           POSIX.SystemError.unsetenv
 public func withCustomEnv(_ env: [String: String], body: () throws -> Void) throws {
-    let state = Array(env.keys).map({ ($0, getenv($0)) })
+    let state = Array(env.keys).map({ ($0, Process.env[$0]) })
     let restore = {
         for (key, value) in state {
             if let value = value {

Sources/Workspace/Destination.swift

@@ -91,7 +91,7 @@ public struct Destination {
       #if os(macOS)
         // Get the SDK.
         let sdkPath: AbsolutePath
-        if let value = lookupExecutablePath(filename: getenv("SDKROOT")) {
+        if let value = lookupExecutablePath(filename: Process.env["SDKROOT"]) {
             sdkPath = value
         } else {
             // No value in env, so search for it.