Tests: Convert Build Command Tests to Swift Testing

Convert the Build Command Tests to Swift Testing,

Make use of parameterized tests to reduce duplication and use
`withKnownIssue` to get signal when tests have been fixed.

Author: bkhouri

Sources/Basics/Process.swift

@@ -19,6 +19,18 @@ public enum OperatingSystem: Hashable, Sendable {
     case unknown
 }
 
+
+public func workingDirectoryIsSupported() -> Bool {
+        #if os(Linux)
+        if FileManager.default.contents(atPath: "/etc/system-release").map({ String(decoding: $0, as: UTF8.self) == "Amazon Linux release 2 (Karoo)\n" }) ?? false {
+            return false
+        }
+        #elseif os(OpenBSD)
+        return false
+        #endif
+        return true
+
+}
 extension ProcessInfo {
     public static var hostOperatingSystem: OperatingSystem {
         #if os(macOS)

Sources/_InternalTestSupport/BuildSystemExtensions.swift

@@ -0,0 +1,36 @@
+//===----------------------------------------------------------------------===//
+//
+// This source file is part of the Swift open source project
+//
+// Copyright (c) 2025 Apple Inc. and the Swift project authors
+// Licensed under Apache License v2.0 with Runtime Library Exception
+//
+// See http://swift.org/LICENSE.txt for license information
+// See http://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
+//
+//===----------------------------------------------------------------------===//
+
+import struct SPMBuildCore.BuildSystemProvider
+import enum PackageModel.BuildConfiguration
+
+extension BuildSystemProvider.Kind {
+
+    public func binPathSuffixes(for config: BuildConfiguration) -> [String] {
+        switch self {
+            case .native:
+                return ["\(config)".lowercased()]
+            case .swiftbuild:
+                return ["Products" , "\(config)".capitalized]
+            case .xcode:
+                return ["apple", "Products" , "\(config)".capitalized]
+        }
+    }
+}
+
+public var SupportedBuildSystemOnPlatform: [BuildSystemProvider.Kind] {
+    #if os(macOS)
+        BuildSystemProvider.Kind.allCases
+    #else
+        BuildSystemProvider.Kind.allCases.filter { $0 != .xcode }
+    #endif
+}

Sources/_InternalTestSupport/SkippedTestSupport.swift

@@ -68,8 +68,25 @@ extension Trait where Self == Testing.ConditionTrait {
                 .map { String(decoding: $0, as: UTF8.self) == "Amazon Linux release 2 (Karoo)\n" } ?? false
         }
     }
+
+    /// Skips the test if running on a platform which lacks the ability for build tasks to set a working directory due to lack of requisite system API.
+    ///
+    /// Presently, relevant platforms include Amazon Linux 2 and OpenBSD.
+    ///
+    /// - seealso: https://github.com/swiftlang/swift-package-manager/issues/8560
+    public static var disableIfWorkingDirectoryUnsupported: Self {
+        disabled("https://github.com/swiftlang/swift-package-manager/issues/8560: Thread-safe process working directory support is unavailable on this platform.") {
+            !workingDirectoryIsSupported()
+        }
+    }
 }
 
+
+extension Trait where Self == Testing.Bug {
+    public static func SWBINTTODO(_ comment: Comment) -> Self {
+        bug(nil, id: 0, comment)
+    }
+}
 extension Tag {
     public enum TestSize {}
     public enum Feature {}
@@ -84,21 +101,23 @@ extension Tag.TestSize {
 extension Tag.Feature {
     public enum Command {}
     public enum PackageType {}
+
+    @Tag public static var CodeCoverage: Tag
 }
 
 extension Tag.Feature.Command {
-    @Tag public static var package: Tag
-    @Tag public static var build: Tag
-    @Tag public static var test: Tag
-    @Tag public static var run: Tag
+    @Tag public static var Package: Tag
+    @Tag public static var Build: Tag
+    @Tag public static var Test: Tag
+    @Tag public static var Run: Tag
 }
 
 extension Tag.Feature.PackageType {
-    @Tag public static var library: Tag
-    @Tag public static var executable: Tag
-    @Tag public static var tool: Tag
-    @Tag public static var plugin: Tag
-    @Tag public static var buildToolPlugin: Tag
-    @Tag public static var commandPlugin: Tag
-    @Tag public static var macro: Tag
+    @Tag public static var Library: Tag
+    @Tag public static var Executable: Tag
+    @Tag public static var Tool: Tag
+    @Tag public static var Plugin: Tag
+    @Tag public static var BuildToolPlugin: Tag
+    @Tag public static var CommandPlugin: Tag
+    @Tag public static var Macro: Tag
 }

Sources/_InternalTestSupport/XCTAssertHelpers.swift

@@ -15,6 +15,7 @@ import Basics
 import class Foundation.Bundle
 #endif
 import SPMBuildCore
+import enum PackageModel.BuildConfiguration
 import TSCTestSupport
 import XCTest
 
@@ -139,7 +140,7 @@ package func XCTAssertAsyncNoThrow<T>(
 
 public func XCTAssertBuilds(
     _ path: AbsolutePath,
-    configurations: Set<Configuration> = [.Debug, .Release],
+    configurations: Set<BuildConfiguration> = [.debug, .release],
     extraArgs: [String] = [],
     Xcc: [String] = [],
     Xld: [String] = [],
@@ -169,7 +170,7 @@ public func XCTAssertBuilds(
 
 public func XCTAssertSwiftTest(
     _ path: AbsolutePath,
-    configuration: Configuration = .Debug,
+    configuration: BuildConfiguration = .debug,
     extraArgs: [String] = [],
     Xcc: [String] = [],
     Xld: [String] = [],

Sources/_InternalTestSupport/misc.swift

@@ -281,7 +281,7 @@ public func getBuildSystemArgs(for buildSystem: BuildSystemProvider.Kind?) -> [S
 @discardableResult
 public func executeSwiftBuild(
     _ packagePath: AbsolutePath?,
-    configuration: Configuration = .Debug,
+    configuration: BuildConfiguration = .debug,
     extraArgs: [String] = [],
     Xcc: [String] = [],
     Xld: [String] = [],
@@ -304,7 +304,7 @@ public func executeSwiftBuild(
 public func executeSwiftRun(
     _ packagePath: AbsolutePath?,
     _ executable: String?,
-    configuration: Configuration = .Debug,
+    configuration: BuildConfiguration = .debug,
     extraArgs: [String] = [],
     Xcc: [String] = [],
     Xld: [String] = [],
@@ -329,7 +329,7 @@ public func executeSwiftRun(
 @discardableResult
 public func executeSwiftPackage(
     _ packagePath: AbsolutePath?,
-    configuration: Configuration = .Debug,
+    configuration: BuildConfiguration = .debug,
     extraArgs: [String] = [],
     Xcc: [String] = [],
     Xld: [String] = [],
@@ -351,7 +351,7 @@ public func executeSwiftPackage(
 @discardableResult
 public func executeSwiftPackageRegistry(
     _ packagePath: AbsolutePath?,
-    configuration: Configuration = .Debug,
+    configuration: BuildConfiguration = .debug,
     extraArgs: [String] = [],
     Xcc: [String] = [],
     Xld: [String] = [],
@@ -373,7 +373,7 @@ public func executeSwiftPackageRegistry(
 @discardableResult
 public func executeSwiftTest(
     _ packagePath: AbsolutePath?,
-    configuration: Configuration = .Debug,
+    configuration: BuildConfiguration = .debug,
     extraArgs: [String] = [],
     Xcc: [String] = [],
     Xld: [String] = [],
@@ -394,7 +394,7 @@ public func executeSwiftTest(
 }
 
 private func swiftArgs(
-    configuration: Configuration,
+    configuration: BuildConfiguration,
     extraArgs: [String],
     Xcc: [String],
     Xld: [String],
@@ -403,9 +403,9 @@ private func swiftArgs(
 ) -> [String] {
     var args = ["--configuration"]
     switch configuration {
-    case .Debug:
+    case .debug:
         args.append("debug")
-    case .Release:
+    case .release:
         args.append("release")
     }
 

Tests/BasicsTests/ConcurrencyHelpersTests.swift

@@ -15,6 +15,9 @@ import Foundation
 import TSCTestSupport
 import Testing
 
+@Suite(
+    .serialized, // as suite may be flaky otherwise
+)
 struct ConcurrencyHelpersTest {
     let queue = DispatchQueue(label: "ConcurrencyHelpersTest", attributes: .concurrent)