Skip to content

Commit 82e7cc0

Browse files
authored
Apply suggestions from code review
1 parent 283cec4 commit 82e7cc0

File tree

5 files changed

+3
-4
lines changed

5 files changed

+3
-4
lines changed

Sources/PackageCollections/API.swift

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -433,7 +433,6 @@ public protocol PackageIndexProtocol {
433433
}
434434

435435
public extension PackageIndexProtocol {
436-
437436
func getPackageMetadata(
438437
identity: PackageIdentity,
439438
location: String?

Sources/PackageCollections/PackageIndexAndCollections.swift

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -254,6 +254,7 @@ public struct PackageIndexAndCollections: Closable {
254254
)
255255
}
256256
}
257+
257258
/// Returns metadata for the package identified by the given `PackageIdentity`, using package index (if configured)
258259
/// and collections data.
259260
///

Sources/PackageCollections/Storage/PackageCollectionsSourcesStorage.swift

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,6 @@ public protocol PackageCollectionsSourcesStorage {
7373
}
7474

7575
public extension PackageCollectionsSourcesStorage {
76-
7776
func list() async throws -> [PackageCollectionsModel.CollectionSource] {
7877
try await safe_async {
7978
self.list(callback: $0)

Sources/PackageCollections/Storage/SQLitePackageCollectionsStorage.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -500,7 +500,6 @@ final class SQLitePackageCollectionsStorage: PackageCollectionsStorage, Closable
500500
}
501501
}
502502
}
503-
504503
func searchTargets(identifiers: [Model.CollectionIdentifier]? = nil,
505504
query: String,
506505
type: Model.TargetSearchType,
@@ -841,6 +840,7 @@ final class SQLitePackageCollectionsStorage: PackageCollectionsStorage, Closable
841840
internal func populateTargetTrie() async throws {
842841
try await safe_async { self.populateTargetTrie(callback: $0) }
843842
}
843+
844844
internal func populateTargetTrie(callback: @escaping (Result<Void, Error>) -> Void = { _ in }) {
845845
// Check to see if there is any data before submitting task to queue because otherwise it's no-op anyway
846846
do {

Sources/SPMTestSupport/misc.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,6 +110,7 @@ public func testWithTemporaryDirectory(
110110
throw error
111111
}
112112
}
113+
113114
@discardableResult public func fixture<T>(
114115
name: String,
115116
createGitRepo: Bool = true,
@@ -162,7 +163,6 @@ fileprivate func verifyFixtureExists(at fixtureSubpath: RelativePath, file: Stat
162163
}
163164

164165
fileprivate func setup(fixtureDir: AbsolutePath, in tmpDirPath: AbsolutePath, copyName: String, createGitRepo: Bool = true) throws -> AbsolutePath {
165-
166166
func copy(from srcDir: AbsolutePath, to dstDir: AbsolutePath) throws {
167167
#if os(Windows)
168168
try localFileSystem.copy(from: srcDir, to: dstDir)

0 commit comments

Comments
 (0)