Skip to content

Commit 61c3ec0

Browse files
committed
Fix testIncorrectDependencies failure on linux due to merge race
1 parent 358e740 commit 61c3ec0

File tree

2 files changed

+4
-7
lines changed

2 files changed

+4
-7
lines changed

Tests/FunctionalTests/PluginTests.swift

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1173,13 +1173,11 @@ final class PluginTests: XCTestCase {
11731173
XCTAssert(stdout.contains("Build complete!"), "output:\n\(stderr)\n\(stdout)")
11741174
}
11751175

1176-
#if os(macOS) // https://github.com/swiftlang/swift-package-manager/issues/8774
11771176
// Try again with the Swift Build build system
11781177
try await fixture(name: "Miscellaneous/Plugins") { path in
11791178
let (stdout, stderr) = try await executeSwiftBuild(path.appending("IncorrectDependencies"), extraArgs: ["--build-system", "swiftbuild", "--build-tests"])
11801179
XCTAssert(stdout.contains("Build complete!"), "output:\n\(stderr)\n\(stdout)")
11811180
}
1182-
#endif
11831181
}
11841182

11851183
func testSandboxViolatingBuildToolPluginCommands() async throws {

Tests/FunctionalTests/TestDiscoveryTests.swift

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -32,16 +32,15 @@ struct TestDiscoveryTests {
3232
@Test(arguments: [BuildSystemProvider.Kind.native, .swiftbuild])
3333
func discovery(_ buildSystem: BuildSystemProvider.Kind) async throws {
3434
try await fixture(name: "Miscellaneous/TestDiscovery/Simple") { fixturePath in
35-
let (stdout, stderr) = try await executeSwiftTest(fixturePath, buildSystem: buildSystem)
35+
let (stdout, stderr) = try await executeSwiftTest(fixturePath, extraArgs: ["-vv"], buildSystem: buildSystem)
3636
// in "swift test" build output goes to stderr
3737
#expect(stderr.contains("Build complete!"))
3838
// in "swift test" test output goes to stdout
3939
#expect(stdout.contains("Executed 3 tests"))
4040
}
4141
}
4242

43-
// FIXME: Fix --build-system swiftbuild link file list quoting on non-Darwin
44-
@Test(arguments: [BuildSystemProvider.Kind.native])
43+
@Test(.bug("https://github.com/swiftlang/swift-build/issues/13"), arguments: [BuildSystemProvider.Kind.native])
4544
func nonStandardName(_ buildSystem: BuildSystemProvider.Kind) async throws {
4645
try await fixture(name: "Miscellaneous/TestDiscovery/hello world") { fixturePath in
4746
let (stdout, stderr) = try await executeSwiftTest(fixturePath, buildSystem: buildSystem)
@@ -64,7 +63,7 @@ struct TestDiscoveryTests {
6463
}
6564

6665
// FIXME: eliminate extraneous warnings with --build-system swiftbuild
67-
@Test(.skipHostOS(.macOS), arguments: [BuildSystemProvider.Kind.native])
66+
@Test(.bug("https://github.com/swiftlang/swift-build/issues/573"), .skipHostOS(.macOS), arguments: [BuildSystemProvider.Kind.native])
6867
func discovery_whenNoTests(_ buildSystem: BuildSystemProvider.Kind) async throws {
6968
try await fixture(name: "Miscellaneous/TestDiscovery/NoTests") { fixturePath in
7069
let (stdout, stderr) = try await executeSwiftTest(fixturePath, buildSystem: buildSystem)
@@ -78,7 +77,7 @@ struct TestDiscoveryTests {
7877
}
7978

8079
// FIXME: --build-system swiftbuild should support hand-authored entry points.
81-
@Test(.skipHostOS(.macOS), arguments: [BuildSystemProvider.Kind.native])
80+
@Test(.bug("https://github.com/swiftlang/swift-build/issues/572"), .skipHostOS(.macOS), arguments: [BuildSystemProvider.Kind.native])
8281
func entryPointOverride(_ buildSystem: BuildSystemProvider.Kind) async throws {
8382
for name in SwiftModule.testEntryPointNames {
8483
try await fixture(name: "Miscellaneous/TestDiscovery/Simple") { fixturePath in

0 commit comments

Comments
 (0)