Update swiftly install one-liner and instructions #936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e source line works. Update the swiftly path for macOS based on installer changes
cmcgee1024
requested review from
0xTim,
alexandersandberg,
davelester,
daveverwer,
dempseyatgithub,
kaishin,
shahmishal,
timsneath and
federicobucchi
as code owners
shahmishal
approved these changes
Mar 27, 2025
shahmishal
added a commit
that referenced
this pull request
Mar 28, 2025
* [install] Add Swiftly to the install page under beta/preview * Adjust the download URLs and instructions to support upcoming swiftly preview release (#857) * Swiftly preview (#866) * Adjust the download URLs and instructions to support upcoming swiftly preview release * Correct the swiftly download URLs --------- Co-authored-by: Mishal Shah <shahmishal@users.noreply.github.com> * Update swiftly install pages (#887) * Tweak wording, replace mac package option with Swiftly * Wording tweaks for Linux, raise Docker prominence. --------- Co-authored-by: Ben Cohen <ben@airspeedvelo.city> * container install directions (#888) Signed-off-by: Eric Ernst <eric_ernst@apple.com> * Update _includes/install/_linux_platforms_tabs.md * Update the install command for Swiftly * Update the Getting started pages for Swiftly * Add copy code button * Shoe copy button only at code block hover * Add copy button for Linux * Don't jump to the platforms on linux page * Fix swiftly macos GSG instructions to remove unnecessary paragraph (#926) * Update swiftly install one-liner and instructions (#936) * Update the one-liners to explicitly set a swiftly home dir so that the source line works. Update the swiftly path for macOS based on installer changes * Add notes about the environment variables and install location customization * Fix awkward wording in install note. * Fix awkward wording in macOS install note * Adjust the one-liners and installation pages for macOS and Linux * Update the install command to use latest swiftly installer --------- Signed-off-by: Eric Ernst <eric_ernst@apple.com> Co-authored-by: Chris McGee <87777443+cmcgee1024@users.noreply.github.com> Co-authored-by: Ben Cohen <airspeedswift@users.noreply.github.com> Co-authored-by: Ben Cohen <ben@airspeedvelo.city> Co-authored-by: Eric Ernst <eric.g.ernst@gmail.com> Co-authored-by: Federico Bucchi <b.federico@gmail.com>
kaishin
pushed a commit
that referenced
this pull request
May 6, 2025
* [install] Add Swiftly to the install page under beta/preview * Adjust the download URLs and instructions to support upcoming swiftly preview release (#857) * Swiftly preview (#866) * Adjust the download URLs and instructions to support upcoming swiftly preview release * Correct the swiftly download URLs --------- Co-authored-by: Mishal Shah <shahmishal@users.noreply.github.com> * Update swiftly install pages (#887) * Tweak wording, replace mac package option with Swiftly * Wording tweaks for Linux, raise Docker prominence. --------- Co-authored-by: Ben Cohen <ben@airspeedvelo.city> * container install directions (#888) Signed-off-by: Eric Ernst <eric_ernst@apple.com> * Update _includes/install/_linux_platforms_tabs.md * Update the install command for Swiftly * Update the Getting started pages for Swiftly * Add copy code button * Shoe copy button only at code block hover * Add copy button for Linux * Don't jump to the platforms on linux page * Fix swiftly macos GSG instructions to remove unnecessary paragraph (#926) * Update swiftly install one-liner and instructions (#936) * Update the one-liners to explicitly set a swiftly home dir so that the source line works. Update the swiftly path for macOS based on installer changes * Add notes about the environment variables and install location customization * Fix awkward wording in install note. * Fix awkward wording in macOS install note * Adjust the one-liners and installation pages for macOS and Linux * Update the install command to use latest swiftly installer --------- Signed-off-by: Eric Ernst <eric_ernst@apple.com> Co-authored-by: Chris McGee <87777443+cmcgee1024@users.noreply.github.com> Co-authored-by: Ben Cohen <airspeedswift@users.noreply.github.com> Co-authored-by: Ben Cohen <ben@airspeedvelo.city> Co-authored-by: Eric Ernst <eric.g.ernst@gmail.com> Co-authored-by: Federico Bucchi <b.federico@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The macOS installer puts swiftly in a different location now that's more understandable.
Update the instructions to reflect the new install location for the macOS packages.
In order to guarantee that the environment file is in the expected location, set the swiftly
environment variables to default to those location on both macOS and Linux.