build: adjust the build on Windows to avoid some warnings #213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We explicitly build cmark-gfm as static. This adjusts the usage to ensure that the module knows that the cmark that it is building against is static. This fixes a number of linker warnings on Windows.
|
@swift-ci please test |
|
This change now means that we can't use the project as a dependency within Xcode: |
|
I’m also running into the same issue when trying to depend on swift-markdown from an iOS project in Xcode.
To address this, I opened #239 describing the problem, and submitted PR #240 that guards the It would be great to get feedback on whether that approach makes sense to merge. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We explicitly build cmark-gfm as static. This adjusts the usage to ensure that the module knows that the cmark that it is building against is static. This fixes a number of linker warnings on Windows.