Skip to content

Conversation

@khanlou
Copy link
Contributor

@khanlou khanlou commented Jan 6, 2025

Bug/issue #, if applicable: #209

Summary

em, strong, and del tags should include their content in a rich format, rather than just their text.

Dependencies

None

Testing

Run this program:

let markdown = "*Here's some **markdown** with a [link](https://khanlou.com)*"

let html = HTMLFormatter.format(markdown)

print(html)

And observe that the nested strong and link tags are included.

Checklist

Make sure you check off the following items. If they cannot be completed, provide a reason.

  • Added tests
  • Ran the ./bin/test script and it succeeded
  • Updated documentation if necessary

Copy link
Contributor

@QuietMisdreavus QuietMisdreavus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@QuietMisdreavus
Copy link
Contributor

@swift-ci Please test

@QuietMisdreavus
Copy link
Contributor

@swift-ci Please test macOS

@QuietMisdreavus QuietMisdreavus merged commit 3588f04 into swiftlang:main Jan 6, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants