Add new Swift API for creating CustomTasks from byte arrays instead of strings #887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f strings Custom task data is often unstructured, and won't be valid UTF-8. Exposing API that works with data instead of strings avoids the need for hacks like base-64 encoding when creating them using the Swift API, and makes it easier to avoid UTF8 encodign overhead.
|
@swift-ci please test |
|
@swift-ci please smoke test |
jakepetroules
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom task data is often unstructured, and won't be valid UTF-8. Exposing API that works with data instead of strings avoids the need for hacks like base-64 encoding when creating them using the Swift API, and makes it easier to avoid UTF8 encoding overhead.
Also, adopt the use of a Swift user module version in llbuild, allowing clients to more easily stage in use of new API
rdar://112936539