Skip to content

Commit 57f5b52

Browse files
finagolfinjohari
authored andcommitted
[CMake] Don't install libllbuild in the Swift toolchain now that it's statically linked
Now that libllbuildSwift is statically linked against libllbuild with #852, remove the runpath and don't install it. Also, the Android build started failing, so set the appropriate flag for it to work again.
1 parent 17e20c3 commit 57f5b52

File tree

3 files changed

+4
-9
lines changed

3 files changed

+4
-9
lines changed

CMakeLists.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,9 @@ else()
5151
endif()
5252
endif()
5353

54+
if(CMAKE_SYSTEM_NAME STREQUAL Android)
55+
set(CMAKE_HAVE_LIBC_PTHREAD TRUE)
56+
endif()
5457
set(THREADS_PREFER_PTHREAD_FLAG FALSE)
5558
find_package(Threads REQUIRED)
5659

products/libllbuild/CMakeLists.txt

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -57,14 +57,6 @@ install(TARGETS libllbuild
5757
RUNTIME DESTINATION bin
5858
COMPONENT libllbuild)
5959

60-
if(Swift IN_LIST LLBUILD_SUPPORT_BINDINGS)
61-
if(NOT CMAKE_SYSTEM_NAME STREQUAL Windows)
62-
install(TARGETS libllbuild
63-
DESTINATION lib/swift/pm/llbuild
64-
COMPONENT libllbuildSwift)
65-
endif()
66-
endif()
67-
6860
add_custom_target(install-libllbuild
6961
DEPENDS libllbuild
7062
COMMENT "Installing libllbuild..."

products/llbuildSwift/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ else()
6565
if(NOT CMAKE_SYSTEM_NAME STREQUAL Windows)
6666
target_link_options(llbuildSwift PRIVATE "SHELL:-no-toolchain-stdlib-rpath")
6767
set_target_properties(llbuildSwift PROPERTIES
68-
INSTALL_RPATH "$ORIGIN:$ORIGIN/../../$<LOWER_CASE:${CMAKE_SYSTEM_NAME}>")
68+
INSTALL_RPATH "$ORIGIN/../../$<LOWER_CASE:${CMAKE_SYSTEM_NAME}>")
6969
endif()
7070
endif()
7171
set_target_properties(llbuildSwift PROPERTIES

0 commit comments

Comments
 (0)