Update test-static-stdlib for swift-foundation #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etcwilde
approved these changes
Jun 20, 2024
MaxDesiatov
approved these changes
Jun 20, 2024
jmschonfeld
added a commit
to jmschonfeld/swift-integration-tests
that referenced
this pull request
Jun 20, 2024
jmschonfeld
added a commit
that referenced
this pull request
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With swift-foundation landing in the toolchain, the behavior of
URL.descriptionhas changed. This test relies on this behavior and it fails with the new toolchain builds. Instead, this updates the tests to callURL.relativePathdirectly (which behaves as the previousURL.descriptiondid but is also consistent in behavior with swift-foundation. This makes the test more reliable and passes with both the old and new Foundation