[6.0.1] URLComponents: support http(s)+unix schemes #914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
jrflat
requested review from
stephentyrone,
jmschonfeld,
shahmishal and
parkera
parkera
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original 6.0 cherry-pick: #903
Description from that cherry-pick:
Explanation: Percent-encode the host (instead of IDNA-encoding) for URLs with the
http+unixorhttps+unixscheme, supporting the common representation of a "HTTP over Unix socket" URL. This fixeshttp(s)+unix-related regressions in clients such as Vapor and AsyncHTTPClient (see #863 and swift-server/async-http-client#767)Scope: Only impacts
http+unixandhttps+unixURLs, adds them to the set ofschemesToPercentEncodeHostOriginal PR: #883
Risk: Low - narrow scope, added special casing of two schemes to a larger set that has been well tested
Testing: Local, swift-ci, stable in
mainfor 2 weeks, verified to fix swift-server/async-http-client#767Reviewer: @parkera