Fix deleteLastPathComponent() for paths with trailing / #897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjmansfield
changed the title
rjmansfield
force-pushed
the
fix-deletingLastPathComponent
branch
from
57e7415 to
4d0d2af
Compare
|
Can someone kick swift-ci for me? Also, can someone review the change? @parkera @jmschonfeld |
|
@swift-ci please test |
jmschonfeld
reviewed
Sep 5, 2024
Tests/FoundationEssentialsTests/FileManager/FileManagerTests.swift
Outdated
Show resolved
Hide resolved
Paths like /home/ would return "" instead of /
rjmansfield
force-pushed
the
fix-deletingLastPathComponent
branch
from
4d0d2af to
0c1e2cf
Compare
jrflat
approved these changes
Sep 5, 2024
|
@swift-ci please test |
|
Thanks, could someone merge on my behalf? |
|
Yes I'll merge it shortly, thanks! |
jmschonfeld
approved these changes
Sep 5, 2024
cthielen
pushed a commit
to cthielen/swift-foundation
that referenced
this pull request
Nov 8, 2024
…ftlang#897) Paths like /home/ would return "" instead of / Co-authored-by: Ryan Mansfield <ryan_mansfield@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paths like /home/ would return "" instead of /