URLComponents: support http(s)+unix schemes #883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
jrflat
force-pushed
the
http-unix-schemes
branch
from
307a45d to
e2f66e8
Compare
|
Fixed conflicts |
|
@swift-ci please test |
parkera
approved these changes
Aug 23, 2024
This was referenced Sep 13, 2024
cthielen
pushed a commit
to cthielen/swift-foundation
that referenced
this pull request
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The common (but not standardized) way to represent an "HTTP over Unix socket" URL is to use the scheme
http+unixand set the URL's host to the percent-encoded path of the socket, e.g.http+unix://%2Fvar%2Frun%2Fdocker.sock/infoBefore the swift-corelibs-foundation re-core,
URLComponentswould always percent-encode the.host, so this worked as expected. After the re-core,URLComponentsnow supports and favors IDNA-encoding of the host, breaking this use case.This PR special-cases the
http+unixandhttps+unixschemes to percent-encode the host like before.