Decimal bin compat: remove the usage of @_cdecl from 'public' methods defined in NSDecimal.h #880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… defined in NSDecimal.h Rationale: @_cdecl emits a C symbol that calls back to the Swift symbol. These new swift symbols does not exist on older OSs, causing a crash due to sym bol not found. Instead of using @_cdecl to implement public methods directly, use it on an internal type so it will not introduce unexpected public symbols. resolves: rdar://133371820
|
@swift-ci please test |
itingliu
approved these changes
Aug 21, 2024
cthielen
pushed a commit
to cthielen/swift-foundation
that referenced
this pull request
Nov 8, 2024
… defined in NSDecimal.h (swiftlang#880)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale: @_cdecl emits a C symbol that calls back to the Swift symbol. These new swift symbols does not exist on older OSs, causing a crash due to sym bol not found. Instead of using @_cdecl to implement public methods directly, use it on an internal type so it will not introduce unexpected public symbols.
resolves: rdar://133371820